I got all the tests green: https://github.com/vlsi/incubator-calcite/commit/25e8f0fe206d18586e551ace0730e73cdfe44606
Is there a good de-correlation test suite somewhere? Currently I get a bit different plan for JdbcTest.testJoinInCorrelatedSubquery, however the test itself verifies just "absence of Correlate", so I am not sure if I broke much. I still do not understand what "join condition" was up to for LogicalCorrelate expression. More to do: 1) Update documentation (checkstyle & friends) 2) Add more tests that execute correlate plans I guess my next step would be to rewrite the de-correlator via patttern-matching rules. I do not like how SqlToRelConverter aggressively inserts aggregates here and there. I would like it to produce simpler SemiJoins/Correlates. Vladimir
