Vladimir, I’ve reviewed your pull request, added a few comments about cosmetic stuff, but your change looks good. It improves the decorrelation architecture, and you’ve added some tricky test cases to prove it. Nice work.
+1 to rebase and check in. Julian On Dec 5, 2014, at 3:57 PM, Julian Hyde <[email protected]> wrote: > Sorry I haven’t gotten to this. I need another couple of days. > > Julian > > On Nov 30, 2014, at 7:12 AM, Vladimir Sitnikov <[email protected]> > wrote: > >> Here's LogicalCorrelate and EnumerableCorrelate: >> https://github.com/apache/incubator-calcite/pull/20 >> >> Tests are fine, so I want some feedback before it is merged. >> >> Vladimir >
