A minor quibble: put a blank line before the ‘fixes #26’, otherwise git will merge it into the commit message.
I thought we reached consensus that contributions from non-committers should have the author’s name at the end of the commit message. Viz: [CALCITE-511] copy method in LogicalAggregate not copying the indicator value properly (Jesus Camacho Rodriguez) fixes #26 Julian On Dec 10, 2014, at 6:32 AM, [email protected] wrote: > Repository: incubator-calcite > Updated Branches: > refs/heads/master f2a67050b -> 155d24f1a > > > [CALCITE-511] copy method in LogicalAggregate not copying the indicator value > properly > fixes #26 > > > Project: http://git-wip-us.apache.org/repos/asf/incubator-calcite/repo > Commit: > http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/155d24f1 > Tree: http://git-wip-us.apache.org/repos/asf/incubator-calcite/tree/155d24f1 > Diff: http://git-wip-us.apache.org/repos/asf/incubator-calcite/diff/155d24f1 > > Branch: refs/heads/master > Commit: 155d24f1aa2b0733e402aca6c2b0ba1ed1ef456b > Parents: f2a6705 > Author: Jesus Camacho Rodriguez <[email protected]> > Authored: Wed Dec 10 17:31:01 2014 +0300 > Committer: Vladimir Sitnikov <[email protected]> > Committed: Wed Dec 10 17:31:42 2014 +0300 > > ---------------------------------------------------------------------- > .../main/java/org/apache/calcite/rel/logical/LogicalAggregate.java | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/incubator-calcite/blob/155d24f1/core/src/main/java/org/apache/calcite/rel/logical/LogicalAggregate.java > ---------------------------------------------------------------------- > diff --git > a/core/src/main/java/org/apache/calcite/rel/logical/LogicalAggregate.java > b/core/src/main/java/org/apache/calcite/rel/logical/LogicalAggregate.java > index dd3e509..72744ad 100644 > --- a/core/src/main/java/org/apache/calcite/rel/logical/LogicalAggregate.java > +++ b/core/src/main/java/org/apache/calcite/rel/logical/LogicalAggregate.java > @@ -82,7 +82,7 @@ public final class LogicalAggregate extends Aggregate { > boolean indicator, ImmutableBitSet groupSet, > List<ImmutableBitSet> groupSets, List<AggregateCall> aggCalls) { > assert traitSet.containsIfApplicable(Convention.NONE); > - return new LogicalAggregate(getCluster(), input, this.indicator, > groupSet, > + return new LogicalAggregate(getCluster(), input, indicator, groupSet, > groupSets, aggCalls); > } > >
