>I thought we reached consensus that contributions from non-committers should 
>have the author’s name at the end of the commit message

I thought it was just a ping-pong of the ours vs HIVE's strategy.

I have no problem applying this convention, however I find this a bit excessive:
1) If anyone reads "commit message", he/she would see who is the
author. Github, etc clearly shows that. I think git solves this
problem in a consistent way.
2) When preparing release notes, git.author can be fetched as
required. It would be easier than using regexp magic to "figure out
author".
3) Akka, postgresql have lots of contributions and they use message
for, well, message.

In my Calcite/Optiq experience (i.e. before being a committer), it was
a pleasure to see "my name" in the git.author field and in the release
notes. I was expecting it to be like that, and it somehow met my
expectations automagically.

-- 
Regards,
Vladimir Sitnikov

Reply via email to