Hi Charles, Did you really verify the James changes on this, as far as I see actually he did *not* change aynthing by this POM as the last revision is still Christian's fix for the failed build on the trunk:
http://svn.apache.org/viewvc/camel/trunk/examples/camel-example-cdi/pom.xml?view=log Question: did you check these two profiles you added through deploying/verifying this example under JBoss/Glassfish? If not then I propose to remove them as IMHO something which doesn't work has no added-value. The other option would be of course to make them work properly. Babak Charles Moulliard-2 wrote > I'm fine with last james's changes. > > On Mon, Sep 24, 2012 at 8:50 PM, Christian Müller < > christian.mueller@ >> wrote: > >> Hey Charles! >> >> No issues with reverting the change, but: >> - the build will fail again (this was the reason of my change). >> - James already did some changes. >> >> Could you please have a look at it and change it as it's needed? >> >> Best, >> Christian >> >> >> On Mon, Sep 24, 2012 at 10:30 AM, Charles Moulliard < > ch007m@ > >wrote: >> >>> Hi Christian, >>> >>> We should revert the modifications as what you have done does not allow >>> anymore to package WAR or JAR and during the deploy phase maven download >>> the file even if it is created during compile phase. >>> >>> Regards, >>> >>> Charles >>> >>> >>> On Mon, Sep 24, 2012 at 8:11 AM, Charles Moulliard < > ch007m@ > >wrote: >>> >>>> Hi Christian, >>>> >>>> Thx. I will have a look. >>>> >>>> Regards, >>>> >>>> Charles >>>> >>>> >>>> On Sat, Sep 22, 2012 at 10:25 PM, Christian Müller < >>>> > christian.mueller@ >> wrote: >>>> >>>>> Hi Charles! >>>>> >>>>> I fixed this with rev 1388892 [1]. Could you please check whether this >>>>> fix looks good for you. >>>>> >>>>> [1] >>>>> http://svn.apache.org/viewvc/camel/trunk/examples/camel-example-cdi/pom.xml?view=diff&r1=1388891&r2=1388892&pathrev=1388892 >>>>> >>>>> Best, >>>>> Christian >>>>> >>>>> >>>>> On Fri, Sep 21, 2012 at 9:19 PM, Babak Vahdat < >>>>> > babak.vahdat@ >> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> Currently the build on the trunk is broken @ camel-example-cdi: >>>>>> >>>>>> [INFO] --- maven-war-plugin:2.1:war (default-war) @ camel-example-cdi >>>>>> --- >>>>>> [INFO] Packaging webapp >>>>>> [INFO] Assembling webapp [camel-example-cdi] in >>>>>> >>>>>> [/Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/target/camel- >>>>>> example-cdi-2.11-SNAPSHOT] >>>>>> [INFO] Processing war project >>>>>> [INFO] Copying webapp webResources >>>>>> >>>>>> [/Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/target/classe >>>>>> s] to >>>>>> >>>>>> [/Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/target/camel- >>>>>> example-cdi-2.11-SNAPSHOT] >>>>>> [INFO] Webapp assembled in [223 msecs] >>>>>> [INFO] Building war: >>>>>> >>>>>> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/target/camel-e >>>>>> xample-cdi-2.11-SNAPSHOT.war >>>>>> [INFO] >>>>>> >>>>>> ------------------------------------------------------------------------ >>>>>> [INFO] BUILD FAILURE >>>>>> [INFO] >>>>>> >>>>>> ------------------------------------------------------------------------ >>>>>> [INFO] Total time: 5.129s >>>>>> [INFO] Finished at: Fri Sep 21 21:17:05 CEST 2012 >>>>>> [INFO] Final Memory: 16M/1011M >>>>>> [INFO] >>>>>> >>>>>> ------------------------------------------------------------------------ >>>>>> [ERROR] Failed to execute goal >>>>>> org.apache.maven.plugins:maven-war-plugin:2.1:war (default-war) on >>>>>> project >>>>>> camel-example-cdi: Error assembling WAR: webxml attribute is required >>>>>> (or >>>>>> pre-existing WEB-INF/web.xml if executing in update mode) -> [Help 1] >>>>>> [ERROR] >>>>>> [ERROR] To see the full stack trace of the errors, re-run Maven with >>>>>> the -e >>>>>> switch. >>>>>> [ERROR] Re-run Maven using the -X switch to enable full debug >>>>>> logging. >>>>>> [ERROR] >>>>>> [ERROR] For more information about the errors and possible solutions, >>>>>> please >>>>>> read the following articles: >>>>>> [ERROR] [Help 1] >>>>>> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException >>>>>> >>>>>> Babak >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Charles Moulliard >>>> Apache Committer / Sr. Enterprise Architect (RedHat) >>>> Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com >>>> >>>> >>>> >>> >>> >>> -- >>> Charles Moulliard >>> Apache Committer / Sr. Enterprise Architect (RedHat) >>> Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com >>> >>> >>> >> >> >> -- >> >> >> > > > -- > Charles Moulliard > Apache Committer / Sr. Enterprise Architect (RedHat) > Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com -- View this message in context: http://camel.465427.n5.nabble.com/Build-on-trunk-fails-camel-example-cdi-tp5719732p5719921.html Sent from the Camel Development mailing list archive at Nabble.com.
