I will correct them.
On Sat, Oct 6, 2012 at 10:21 AM, Babak Vahdat
<babak.vah...@swissonline.ch>wrote:
> Hi Charles,
>
> after your latest changes by this example there're again a bunch of
> checkstyle violations which I could not fix as after fixing them all, the
> new tests of yours started failing!
>
> ~/dev/workspace/camel/examples/camel-example-cdi>mvn clean install
> -Psourcecheck
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building Camel :: Example :: CDI 2.11-SNAPSHOT
> [INFO]
> ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ camel-example-cdi
> ---
> [INFO] Deleting
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/target
> [INFO]
> [INFO] --- maven-bundle-plugin:2.3.7:cleanVersions (versions) @
> camel-example-cdi ---
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.6:checkstyle (validate) @
> camel-example-cdi ---
> [INFO] Starting audit...
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/ArchiveUtil.java:1:
> Zeile entspricht nicht der erwarteten Header-Zeile '/**'.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/ArchiveUtil.java:13:
> Falsche Reihenfolge f?r import von 'java.io.File'.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/ArchiveUtil.java:18:1:
> Utility classes should not have a public or default constructor.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/ArchiveUtil.java:43:56:
> Nach ',' folgt kein Leerzeichen.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/ArchiveUtil.java:43:85:
> Nach ',' folgt kein Leerzeichen.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/one/DeploymentFactory.java:26:1:
> Utility classes should not have a public or default constructor.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/one/DeploymentFactory.java:28:27:
> 'WELD_EMBEDDED_CONTAINER' entspricht nicht dem Muster
> '^[a-z][a-zA-Z0-9]*$'.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/one/DeploymentFactory.java:29:27:
> 'JBOSSAS_MANAGED_CONTAINER' entspricht nicht dem Muster
> '^[a-z][a-zA-Z0-9]*$'.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/one/DeploymentFactory.java:39:61:
> Nach ',' folgt kein Leerzeichen.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/one/IntegrationTest.java:25:1:
> ?berfl?ssiges import aus demselben Package -
> org.apache.camel.example.cdi.one.DeploymentFactory.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/one/IntegrationTest.java:35:
> Falsche Reihenfolge f?r import von
> 'javax.enterprise.context.ApplicationScoped'.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/one/IntegrationTest.java:48:5:
> Fehlerhafte Deklarationsreihenfolge f?r diesen Scope.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/one/IntegrationTest.java:64:13:
> '{' sollte in der vorhergehenden Zeile stehen.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/DeploymentFactory.java:26:1:
> Utility classes should not have a public or default constructor.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/DeploymentFactory.java:28:27:
> 'WELD_EMBEDDED_CONTAINER' entspricht nicht dem Muster
> '^[a-z][a-zA-Z0-9]*$'.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/DeploymentFactory.java:29:27:
> 'JBOSSAS_MANAGED_CONTAINER' entspricht nicht dem Muster
> '^[a-z][a-zA-Z0-9]*$'.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/DeploymentFactory.java:38:61:
> Nach ',' folgt kein Leerzeichen.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/SeparateRouteBuilderIntegrationTest.java:21:1:
> ?berfl?ssiges import aus demselben Package -
> org.apache.camel.example.cdi.two.DeploymentFactory.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/SeparateRouteBuilderIntegrationTest.java:22:
> Falsche Reihenfolge f?r import von 'org.apache.camel.example.cdi.MyRoutes'.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/SeparateRouteBuilderIntegrationTest.java:23:
> Die Form '.*' f?r import-Anweisungen sollte vermieden werden -
> org.apache.camel.example.cdi.one.*.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/SeparateRouteBuilderIntegrationTest.java:24:1:
> ?berfl?ssiges import aus demselben Package -
> org.apache.camel.example.cdi.two.TestRouteBuilder.
>
> /Users/bvahdat/dev/workspace/camel/examples/camel-example-cdi/src/test/java/org/apache/camel/example/cdi/two/SeparateRouteBuilderIntegrationTest.java:34:
> Falsche Reihenfolge f?r import von 'javax.inject.Inject'.
> Audit done.
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 3.951s
> [INFO] Finished at: Sat Oct 06 10:12:16 CEST 2012
> [INFO] Final Memory: 20M/1011M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:2.6:checkstyle (validate)
> on project camel-example-cdi: An error has occurred in Checkstyle report
> generation. Failed during checkstyle execution: There are 22 checkstyle
> errors. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
> please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
>
> Babak
>
>
> Charles Moulliard-2 wrote
> > Checkstyle corrections committed
> >
> > Remark : Even if the project is started with Glassfish 3.2-b06, the camel
> > routes are not created and camelContext too !
> >
> > On Tue, Sep 25, 2012 at 6:59 PM, Charles Moulliard <
>
> > ch007m@
>
> > > wrote:
> >
> >> Will fix checkstyle and make a test with GlassFish 3.2
> >>
> >>
> >> On Tue, Sep 25, 2012 at 6:44 PM, Babak Vahdat <
>
> > babak.vahdat@
>
> > > > wrote:
> >>
> >>> I already resolved the Glassfish-Profile issue (on my workspace) which
> >>> would
> >>> make it possible to run this example using Glassfish 3.2-b06 as well.
> >>> Will
> >>> commit the fix either late @ tonight or tomorrow.
> >>>
> >>> @Charles: the last missing piece to fix are the 5 checkstyle violations
> >>> by
> >>> your last 2 commits, would you please fix them as well. Thanks!
> >>>
> >>> Babak
> >>>
> >>>
> >>> Charles Moulliard-2 wrote
> >>> > I will commit code soon as the jboss profile works now. Glassfish
> >>> issue
> >>> is
> >>> > still there, so the profile will be commented in the pom file.
> >>> >
> >>> > On Tue, Sep 25, 2012 at 1:59 PM, Babak Vahdat
> >>> > <
> >>>
> >>> > babak.vahdat@
> >>>
> >>> > >wrote:
> >>> >
> >>> >> > Babak,
> >>> >> >
> >>> >> > The two profiles are currently used to control/check deployment of
> >>> >> camel
> >>> >> > in
> >>> >> > Glassfish/JBoss and works fine.
> >>> >>
> >>> >> No none of those profiles work properly. I raised a ticket so we
> >>> don't
> >>> >> forget this:
> >>> >>
> >>> >> https://issues.apache.org/jira/browse/CAMEL-5648
> >>> >>
> >>> >> Babak
> >>> >>
> >>> >> > As they don't perturbate the
> >>> >> > build/packaging of camel, we do not have to remove it.
> >>> >> >
> >>> >> > Regards,
> >>> >> >
> >>> >> > Charles
> >>> >>
> >>> >>
> >>> >>
> >>> >> --
> >>> >> View this message in context:
> >>> >>
> >>>
> http://camel.465427.n5.nabble.com/Build-on-trunk-fails-camel-example-cdi-tp5719732p5719938.html
> >>> >> Sent from the Camel Development mailing list archive at Nabble.com.
> >>> >>
> >>> >
> >>> >
> >>> >
> >>> > --
> >>> > Charles Moulliard
> >>> > Apache Committer / Sr. Enterprise Architect (RedHat)
> >>> > Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> --
> >>> View this message in context:
> >>>
> http://camel.465427.n5.nabble.com/Build-on-trunk-fails-camel-example-cdi-tp5719732p5719964.html
> >>> Sent from the Camel Development mailing list archive at Nabble.com.
> >>>
> >>
> >>
> >>
> >> --
> >> Charles Moulliard
> >> Apache Committer / Sr. Enterprise Architect (RedHat)
> >> Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com
> >>
> >>
> >>
> >
> >
> > --
> > Charles Moulliard
> > Apache Committer / Sr. Enterprise Architect (RedHat)
> > Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com
>
>
>
>
>
> --
> View this message in context:
> http://camel.465427.n5.nabble.com/Build-on-trunk-fails-camel-example-cdi-tp5719732p5720666.html
> Sent from the Camel Development mailing list archive at Nabble.com.
>
--
Charles Moulliard
Apache Committer / Sr. Enterprise Architect (RedHat)
Twitter : @cmoulliard | Blog : http://cmoulliard.blogspot.com
