Am 20.11.13 13:37 schrieb "Babak Vahdat" unter <babak.vah...@swissonline.ch>:
> > >Am 20.11.13 12:22 schrieb "Claus Ibsen" unter <claus.ib...@gmail.com>: > >>Its not really a bug, its the namespace the JAXB classes in camel-core >>has been used since early days. > >Hi Claus, > >Thanks for your feedback! > >IMHO when you say "Its not really a bug" then it depends whose hat you >have on. As an Apache Camel committer bearing the whole Camel history in >mind: yes, looking back at the history of this framework and how and in >which direction it grew up, for sure you can claim that but NOT as a Camel >user who EXPECTS a properly working framework beneath his foots. > >Also note that the same WRONG XML namespace declaration would arise as >well if a user would make use of the corresponding JMX operation: >ManagedCamelContextMBean#dumpRoutesAsXml() > >That all said I also think we should postpone this to Camel 3.0 as I guess >fixing this right now without breaking the backward compatibility would be >almost immpossible. > >And as always, sorry for my poor English. :( Oops, typed a bit too fast :) "beneath his foots” => "beneath his feet" "immpossible" => "impossible" Babak > >Babak > > >>Back then Spring was the only XML DSL supported. And its the namespace >>the model classes is hardcoded to use. >> >>In Camel 3.0 we can consider having a /core namespace instead of >>/spring for the JAXB classes, and then in camel-spring and >>camel-blueprint replace /core with /spring and /blueprint to keep >>their namespaces in their domain. >> >> >> >> >>On Wed, Nov 20, 2013 at 12:09 PM, Babak Vahdat >><babak.vah...@swissonline.ch> wrote: >>> Hi >>> >>> As working on CAMEL-6985 last night I spotted a bug concerning the >>>blueprint >>> based Camel apps. Following the steps to reproduce: >>> >>> - Install the Twitter-Websocket-Blueprint example into the Karaf and >>>then >>> make use of the 'route-info' command for it as below: >>> >>> ~/dev/apache-karaf-2.3.3/bin>./karaf clean >>> __ __ ____ >>> / //_/____ __________ _/ __/ >>> / ,< / __ `/ ___/ __ `/ /_ >>> / /| |/ /_/ / / / /_/ / __/ >>> /_/ |_|\__,_/_/ \__,_/_/ >>> >>> Apache Karaf (2.3.3) >>> >>> Hit '<tab>' for a list of available commands >>> and '[cmd] --help' for help on a specific command. >>> Hit '<ctrl-d>' or type 'osgi:shutdown' or 'logout' to shutdown Karaf. >>> >>> karaf@root> features:chooseurl camel 2.13-SNAPSHOT >>> adding feature url >>> mvn:org.apache.camel.karaf/apache-camel/2.13-SNAPSHOT/xml/features >>> karaf@root> features:install camel-blueprint camel-twitter >>>camel-websocket >>> karaf@root> osgi:install -s >>> >>>mvn:org.apache.camel/camel-example-twitter-websocket-blueprint/2.13-SNAP >>>S >>>HOT >>> Bundle ID: 85 >>> karaf@root> route-info twitter-route >>> Camel Route twitter-route >>> Camel Context: twitter-camel >>> >>> Properties >>> id = twitter-route >>> parent = 6493bb37 >>> >>> Statistics >>> Inflight Exchanges: 0 >>> Exchanges Total: 19 >>> Exchanges Completed: 19 >>> Exchanges Failed: 0 >>> Min Processing Time: 0 ms >>> Max Processing Time: 4 ms >>> Mean Processing Time: 0 ms >>> Total Processing Time: 14 ms >>> Last Processing Time: 1 ms >>> Delta Processing Time: 1 ms >>> Load Avg: 0.00, 0.00, 0.00 >>> Reset Statistics Date: 2013-11-20 11:53:55 >>> First Exchange Date: 2013-11-20 11:53:57 >>> Last Exchange Completed Date: 2013-11-20 11:54:02 >>> >>> Definition >>> <?xml version="1.0" encoding="UTF-8" standalone="yes"?> >>> <route customId="true" id="twitter-route" >>> xmlns="http://camel.apache.org/schema/spring";> >>> <from >>>uri="twitter://search?type=polling&delay=5&keywords=gaga >>> >>>&accessToken={{access.token}}&accessTokenSecret={{access.token-s >>>e >>>cret}}&consumerKey={{consumer.key}}&consumerSecret={{consumer.se >>>c >>>ret}}"/> >>> <to uri="log:tweet" id="to1"/> >>> <to >>> >>>uri="websocket://localhost:9090/camel-tweet?sendToAll=true&staticRes >>>o >>>urces=classpath:webapp" >>> id="to2"/> >>> </route> >>> >>> >>> And as you see the XML namespace is wrong: >>> http://camel.apache.org/schema/spring instead of >>> http://camel.apache.org/schema/blueprint >>> >>> Actually this bug has nothing to do with the Karaf command itself but >>>the >>> way how our JAXB namespace is definded, as an example see: >>> >>> >>>https://github.com/apache/camel/blob/master/camel-core/src/main/java/org >>>/ >>>apache/camel/model/package-info.java >>> >>> We also have got already a hack by camel-blueprint to fix up the XML >>> namespace from spring to blueprint and vice versa which doesn't help >>>here >>> much (CamelNamespaceHandler#renameNamespaceRecursive). I think somehow >>>we >>> have to make the ModelHelper utility a bit more clever. BTW this bug >>>seems >>> to be there since ages. >>> >>> I have neither looked into this in detail nor raised a JIRA for it. >>> >>> Babak >>> >>> >>> Claus Ibsen-2 wrote >>>> Okay lets try to get this release out. >>>> >>>> Its 2 months since the last patch release of 2.12.x was out. >>>> >>>> >>>> >>>> On Tue, Nov 19, 2013 at 4:57 PM, Hadrian Zbarcea < >>> >>>> hzbarcea@ >>> >>>> > wrote: >>>>> After Willem's fix last night all tests are now passing (with one >>>>> intermittent test failure in camel-jms, I believe timing related). >>>>>Please >>>>> let me know today, what are the issues you're working on we must have >>>>>in >>>>> 2.12.2 so we could close down on the release. >>>>> >>>>> Thanks, >>>>> Hadrian >>>>> >>>>> >>>>> On 11/17/2013 07:54 PM, Hadrian Zbarcea wrote: >>>>>> >>>>>> There are test failure(s) I need to look at: >>>>>> >>>>>> Are there any other issues you absolutely need in 2.12.2? >>>>>> >>>>>> Hadrian >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On 11/12/2013 08:11 PM, Willem jiang wrote: >>>>>>> >>>>>>> +1, >>>>>>> BTW, it looks Camel 2.12.x is catch up the release cycle of Camel >>>>>>> 2.11.x. >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Willem Jiang >>>>>>> >>>>>>> Red Hat, Inc. >>>>>>> Web: http://www.redhat.com >>>>>>> Blog: http://willemjiang.blogspot.com >>>>>>> (http://willemjiang.blogspot.com/) (English) >>>>>>> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese) >>>>>>> Twitter: willemjiang >>>>>>> Weibo: 姜宁willem >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Wednesday, November 13, 2013 at 5:13 AM, Christian Müller wrote: >>>>>>> >>>>>>>> +1 >>>>>>>> >>>>>>>> Best, >>>>>>>> Christian >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Nov 12, 2013 at 5:24 PM, Claus Ibsen < >>> >>>> claus.ibsen@ >>> >>>> >>>> (mailto: >>> >>>> claus.ibsen@ >>> >>>> )> wrote: >>>>>>>> >>>>>>>>> On Mon, Nov 11, 2013 at 7:52 PM, Hadrian Zbarcea < >>> >>>> hzbarcea@ >>> >>>> >>>>> (mailto: >>> >>>> hzbarcea@ >>> >>>> )> >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> I wanted to say the same thing. Maybe even sooner in the month. >>>>>>>>>>How >>>>>>>>>> about >>>>>>>>>> shooting to build the release end of this week. I can take care >>>>>>>>>>of >>>>>>>>>> this >>>>>>>>>> release. >>>>>>>>>> >>>>>>>>>> Hadrian >>>>>>>>> >>>>>>>>> >>>>>>>>> Yeah that works for me too. Just thought it was about time we cut >>>>>>>>>a >>>>>>>>> new patch release for the 2.12 branch now that we have 100+ jiras >>>>>>>>> resolved. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 11/11/2013 01:33 PM, Claus Ibsen wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hi >>>>>>>>>>> >>>>>>>>>>> I think we should cut a new 2.12.2 release later this month. We >>>>>>>>>>> have >>>>>>>>>>> so far 115 jira's resolved. >>>>>>>>>>> >>>>>>>>>>> Any thoughts? >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Claus Ibsen >>>>>>>>> ----------------- >>>>>>>>> Red Hat, Inc. >>>>>>>>> Email: >>> >>>> cibsen@ >>> >>>> (mailto: >>> >>>> cibsen@ >>> >>>> ) >>>>>>>>> Twitter: davsclaus >>>>>>>>> Blog: http://davsclaus.com >>>>>>>>> Author of Camel in Action: http://www.manning.com/ibsen >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Claus Ibsen >>>> ----------------- >>>> Red Hat, Inc. >>>> Email: >>> >>>> cibsen@ >>> >>>> Twitter: davsclaus >>>> Blog: http://davsclaus.com >>>> Author of Camel in Action: http://www.manning.com/ibsen >>> >>> >>> >>> >>> >>> -- >>> View this message in context: >>>http://camel.465427.n5.nabble.com/DISCUSS-Apache-Camel-2-12-2-release-la >>>t >>>er-this-month-tp5743058p5743570.html >>> Sent from the Camel Development mailing list archive at Nabble.com. >> >> >> >>-- >>Claus Ibsen >>----------------- >>Red Hat, Inc. >>Email: cib...@redhat.com >>Twitter: davsclaus >>Blog: http://davsclaus.com >>Author of Camel in Action: http://www.manning.com/ibsen > >
