On 07/01/15 16:47, Daniel Pocock wrote: > On 07/01/15 10:18, Daniel Pocock wrote: >> On 07/01/15 03:19, Willem Jiang wrote: >>> I just send a PR by applying the patch of creating OSGi bundle for jSMPP. >>> Now Camel can consume the new jSMPP bundle from the Official release :) >> >> I've just released jSMPP 2.2.1 with that change, please let me know if >> it looks correct, it has been released through Sonatype and should be >> available for Maven users soon. >> >> Would you be able to tweak the camel-smpp/pom.xml as well? > > Actually, I tried this on a branch and I found that some of the test > cases needed to be tweaked for some API changes > https://github.com/dpocock/camel/tree/dpocock-jsmpp-update > > I made an issue for it too: > https://issues.apache.org/jira/browse/CAMEL-8215 > > After compiling, some of the unit tests fail and one gives an error > > I'll need to look more closely to see what else changed in jSMPP and > whether it needs to be tweaked in jSMPP or in camel-smpp > > There were some things in the unit tests that were obvious though so > they are already fixed. > > One of the things that changes is that Alphabet now supports all the > permitted values and it is not always assumed that the lower 2 bits are > the message class. This may impact test cases that expect a specific > binary data coding value. >
It seems that there is a lot of 2.2.0 stuff in the jsmpp repository that needs more testing before using it with Camel. I also found that the Github repository didn't contain the commit used to produce the 2.1.0 release that Camel currently relies on. Therefore, I did the following: - I found the old SVN (link is missing on Google code, but the URL works) and made a fully mirror into Github using sync2git at https://github.com/opentelecoms-org/jsmpp-svn-mirror - looking in the SVN mirror I found another branch called "2.0.1 sandbox" that doesn't exist at all in the uudashr/jsmpp Git repository. This is the branch that was used to make the last stable release. - I used git format-patch to extract the commits from the branch and put them into the new repository on a branch called 2.0.1_sandbox - I put a tag on the commit corresponding to the 2.1.0 source that is already in use - from the head of that branch I started a release-2.1 branch where I have just backported the fix for the concurrent modification exception and the pom.xml for the bundle - then I produced a 2.1.1 release and uploaded it the Maven repository The camel-smpp unit tests run fine with jsmpp-2.1.1 so I would suggest using that to begin with and later on we can upgrade the camel-smpp component to work with 2.2.0 I submitted a new pull request for 2.1.1
