Hi Claus, thank you for the review, I've updated #1338. Sorry for submitting big PRs like that, I've tried to separate the concerns and to make them as small as they can be to facilitate the review, and thus the 3 separate PRs.
So the three pull requests all together support the two distinct new features belonging to a common subset of Salesforce REST APIs the Composite API: #1338 - Composite API SObject tree creation, a way to create multiple records in Salesforce including parent-child relationships #1344 - Composite API batch, a way to group up to 25 requests into a single batch And those build upon the metadata support in the #1334. So #1334 would need to be merged first #1338 rebased and merged and then #1344 rebased and merged. zoran On Tue, Dec 13, 2016 at 7:58 PM, Claus Ibsen <claus.ib...@gmail.com> wrote: > Hi > > I think maybe Dhiraj would be more ideal to help review. > > I took a look at 1334 and it look good to me. > > And is 1338 a new feature about composite apis. So is the need for > this to do bulk API calls and get a big response with a tree that has > composite data you need? > > From my pov they look good, only a few minor things which I reported > on the github tickets > > On Tue, Dec 13, 2016 at 10:33 AM, Zoran Regvart <zo...@regvart.com> wrote: >> Hi devs, >> I added a new feature to the Salesforce component (Composite API >> SObject tree creation), that ended up needing changes in the maven >> plugin to generate metadata in the DTOs. The two resulting pull >> requests are: >> https://github.com/apache/camel/pull/1334 and >> https://github.com/apache/camel/pull/1338 >> >> I would like to continue and build upon that for the next part of the >> Composite API (batch). >> >> Would someone like to review those PRs and work with me to get them >> merged upstream? >> >> thanks :) >> >> zoran >> -- >> Zoran Regvart > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 -- Zoran Regvart
