On Wed, Dec 14, 2016 at 9:51 AM, Zoran Regvart <zo...@regvart.com> wrote: > Hi, > thank you Luca and Claus for having a look, I'm writing here if > someone is not looking at the github PRs. > > I have another question. This functionality brings about performance > improvement to the users and it might be interesting to Java 7 > (2.17.x) users as well. > > Do you think that it would be better if the code was Java 7 based (I'm > using method references, lambdas and streams quite liberally) so that > it can be merged into 2.17.x as well? > > If I base the code on Java 7 I think it could be merged to 2.17.x as is. >
No the older branches are in maintenance mode and only bug fixes and small improvements are considered. eg we want to keep the code stable as-is. And only do big changes on master branches. > zoran > > On Tue, Dec 13, 2016 at 9:33 PM, Zoran Regvart <zo...@regvart.com> wrote: >> Hi Claus, >> thank you for the review, I've updated #1338. Sorry for submitting big >> PRs like that, I've tried to separate the concerns and to make them as >> small as they can be to facilitate the review, and thus the 3 separate >> PRs. >> >> So the three pull requests all together support the two distinct new >> features belonging to a common subset of Salesforce REST APIs the >> Composite API: >> #1338 - Composite API SObject tree creation, a way to create multiple >> records in Salesforce including parent-child relationships >> #1344 - Composite API batch, a way to group up to 25 requests into a >> single batch >> >> And those build upon the metadata support in the #1334. So #1334 would >> need to be merged first #1338 rebased and merged and then #1344 >> rebased and merged. >> >> zoran >> >> On Tue, Dec 13, 2016 at 7:58 PM, Claus Ibsen <claus.ib...@gmail.com> wrote: >>> Hi >>> >>> I think maybe Dhiraj would be more ideal to help review. >>> >>> I took a look at 1334 and it look good to me. >>> >>> And is 1338 a new feature about composite apis. So is the need for >>> this to do bulk API calls and get a big response with a tree that has >>> composite data you need? >>> >>> From my pov they look good, only a few minor things which I reported >>> on the github tickets >>> >>> On Tue, Dec 13, 2016 at 10:33 AM, Zoran Regvart <zo...@regvart.com> wrote: >>>> Hi devs, >>>> I added a new feature to the Salesforce component (Composite API >>>> SObject tree creation), that ended up needing changes in the maven >>>> plugin to generate metadata in the DTOs. The two resulting pull >>>> requests are: >>>> https://github.com/apache/camel/pull/1334 and >>>> https://github.com/apache/camel/pull/1338 >>>> >>>> I would like to continue and build upon that for the next part of the >>>> Composite API (batch). >>>> >>>> Would someone like to review those PRs and work with me to get them >>>> merged upstream? >>>> >>>> thanks :) >>>> >>>> zoran >>>> -- >>>> Zoran Regvart >>> >>> >>> >>> -- >>> Claus Ibsen >>> ----------------- >>> http://davsclaus.com @davsclaus >>> Camel in Action 2: https://www.manning.com/ibsen2 >> >> >> >> -- >> Zoran Regvart > > > > -- > Zoran Regvart -- Claus Ibsen ----------------- http://davsclaus.com @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
