+1 On Wed, May 23, 2018 at 8:14 AM, Luca Burgazzoli <lburgazz...@gmail.com> wrote:
> A very simple example is: > > https://github.com/lburgazzoli/apache-camel/blob/ > CAMEL-12485/platforms/spring-boot/components-starter/camel- > consul-starter/src/test/java/org/apache/camel/component/ > consul/springboot/cloud/ConsulServiceRegistryIT.java#L45 > > There is then some code used to customize logging and to wait for the > container to start up which I'd like to move to a common test > component and if would be nice to have some methods in a new > "ContainerizedCameltestSupport" class to overload to easily customize > container's behavior. > > --- > Luca Burgazzoli > > > On Wed, May 23, 2018 at 12:35 AM, Willem Jiang <willem.ji...@gmail.com> > wrote: > > Hi > > > > I just go through the test container introduction, > > it's cool that we can start the container in the Java unit test. > > > > @Luca > > Could you provide a typic use case(with code) of using > camel-testcontainers? > > Normally, we just need to spin up the service image for the testing, I > > think testcontainer already provide a good API for it. > > > > @Zoran, > > I think we don't need to change all the Unit test to JUnit5 at one time. > > We can just start to use JUnit5 with the camel integration test first. > > > > > > > > Willem Jiang > > > > Blog: http://willemjiang.blogspot.com (English) > > http://jnn.iteye.com (Chinese) > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Wed, May 23, 2018 at 4:03 AM, Zoran Regvart <zo...@regvart.com> > wrote: > > > >> Hi Luca, > >> sounds like a good idea, would be really good if we transitioned (no > >> need for a big bang), to JUnit 5 then we could use conditional logic > >> to skip those tests if for instance docker is not available. > >> > >> I would also consider marking those as integration tests so they are > >> run only if we want them to be run, or in environments that we know > >> they'll run without issues. > >> > >> zoran > >> > >> On Tue, May 22, 2018 at 5:35 PM, Luca Burgazzoli <lburgazz...@gmail.com > > > >> wrote: > >> > Hi all, > >> > > >> > I've been using testcontainers [1] for a while and I found it useful > >> > to test against non java services such as consul, etcd and so on so > >> > I'd like to create a camel-testcontainers "component" that includes > >> > some facilities like a dedicated test support that take care of > >> > starting/stopping containers. > >> > > >> > Any objection/suggestion ? > >> > > >> > Regards, > >> > Luca > >> > > >> > [1] https://www.testcontainers.org/ > >> > > >> > > >> > --- > >> > Luca Burgazzoli > >> > >> > >> > >> -- > >> Zoran Regvart > >> >
