Hi Luca, +1 as you demonstrated the use to test starters.
I already faced a situation where a custom docker image would have helped in testing a regular camel component. Would it be in the scope of camel-testcontainers ? I mean building a custom image, pushing it to docker hub and use that for route level tests of a regular component ? Alex On Wed, May 23, 2018 at 9:39 AM, Luca Burgazzoli <[email protected]> wrote: > Like: > > https://github.com/lburgazzoli/apache-camel/blob/ > CAMEL-12485/platforms/spring-boot/components-starter/camel- > consul-starter/pom.xml#L67-L128 > > > --- > Luca Burgazzoli > > > On Wed, May 23, 2018 at 9:38 AM, Luca Burgazzoli <[email protected]> > wrote: > > It can be done by checking the presence of the docker socket file or > > DOCKER_HOST env var > > > > --- > > Luca Burgazzoli > > > > > > On Wed, May 23, 2018 at 8:56 AM, Willem Jiang <[email protected]> > wrote: > >> Hi Luca, > >> > >> I guess you mean the maven profile. Please correct me if I'm wrong. > >> Currently I need to user -Pdocker to enable the docker related test in > my > >> project. > >> > >> I'm not sure if we enable the profile by default if there is a docker > >> command in the box. > >> > >> > >> > >> Willem Jiang > >> > >> Blog: http://willemjiang.blogspot.com (English) > >> http://jnn.iteye.com (Chinese) > >> Twitter: willemjiang > >> Weibo: 姜宁willem > >> > >> On Wed, May 23, 2018 at 2:22 PM, Luca Burgazzoli <[email protected] > > > >> wrote: > >> > >>> Hi Zoran, > >>> > >>> On Tue, May 22, 2018 at 10:03 PM, Zoran Regvart <[email protected]> > wrote: > >>> > Hi Luca, > >>> > sounds like a good idea, would be really good if we transitioned (no > >>> > need for a big bang), to JUnit 5 then we could use conditional logic > >>> > to skip those tests if for instance docker is not available. > >>> > > >>> > I would also consider marking those as integration tests so they are > >>> > run only if we want them to be run, or in environments that we know > >>> > they'll run without issues. > >>> > > >>> > >>> As first iteration I'd use profiles, junit 5 is not exatly as easy as > >>> junit 4 is. > >>> > >>> > zoran > >>> > > >>> > On Tue, May 22, 2018 at 5:35 PM, Luca Burgazzoli < > [email protected]> > >>> wrote: > >>> >> Hi all, > >>> >> > >>> >> I've been using testcontainers [1] for a while and I found it useful > >>> >> to test against non java services such as consul, etcd and so on so > >>> >> I'd like to create a camel-testcontainers "component" that includes > >>> >> some facilities like a dedicated test support that take care of > >>> >> starting/stopping containers. > >>> >> > >>> >> Any objection/suggestion ? > >>> >> > >>> >> Regards, > >>> >> Luca > >>> >> > >>> >> [1] https://www.testcontainers.org/ > >>> >> > >>> >> > >>> >> --- > >>> >> Luca Burgazzoli > >>> > > >>> > > >>> > > >>> > -- > >>> > Zoran Regvart > >>> >
