lburgazzoli commented on issue #257: chore: add all sorts of linters and pre-commit hook URL: https://github.com/apache/camel-k/pull/257#issuecomment-444481172 The pre commit hook config is part of the pr and the docs seems to require to set it up, I know I can skip them but imo it is better to put it as make target and eventually document how to set up hooks as part of the workfkow. Putting the pre commit hook config in the repo has also the drawback that may conflict whit others hook one may have as part of the personal workfkow. Btw I have no objection against lint especially with go but I do not like forcing a specific local workflow On Wed, 5 Dec 2018 at 14:05, Zoran Regvart <[email protected]> wrote: > for what it's worth, I do not like at all installing pre commit hooks :) > > Then don't add them to your local .git :) > > — > You are receiving this because your review was requested. > > > Reply to this email directly, view it on GitHub > <https://github.com/apache/camel-k/pull/257#issuecomment-444478019>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AByEhfrmh1rZ52hn_lhnXDsNKTYetiO6ks5u18R-gaJpZM4ZClFf> > . > -- -- Luca Burgazzoli
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
