lburgazzoli commented on issue #257: chore: add all sorts of linters and pre-commit hook URL: https://github.com/apache/camel-k/pull/257#issuecomment-444484651 if one has alteady a pre commit hook configured for camel-k, then the set up put in the repo will conflict with it, correct ? On Wed, 5 Dec 2018 at 14:21, Zoran Regvart <[email protected]> wrote: > The pre commit hook config is part of the pr and the docs seems to require > to set it up, I know I can skip them but imo it is better to put it as make > target and eventually document how to set up hooks as part of the workfkow. > Putting the pre commit hook config in the repo has also the drawback that > may conflict whit others hook one may have as part of the personal workfkow. > > I can update the docs to make it clear that installing pre-commit hook is > optional and depends on personal preference. Adding > .pre-commit-config.yaml should not affect any personal workflow you have, > as it is read by the pre-commit hook installed via pre-commit framework > <https://pre-commit.com/>. > > Don't install pre-commit framework or don't run pre-commit install and > your workflow should not be changed. > > — > You are receiving this because your review was requested. > > > Reply to this email directly, view it on GitHub > <https://github.com/apache/camel-k/pull/257#issuecomment-444482908>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AByEhc4UfapsmdLnP5h708spqtDA3BaNks5u18hegaJpZM4ZClFf> > . > -- -- Luca Burgazzoli
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
