astefanutti commented on a change in pull request #583: Split builder from
operator
URL: https://github.com/apache/camel-k/pull/583#discussion_r272179244
##########
File path: pkg/builder/kaniko/publisher.go
##########
@@ -111,6 +111,12 @@ func Publisher(ctx *builder.Context) error {
args = baseArgs
}
+ // The pod will be scheduled to nodes that are selected by the
persistent volume
Review comment:
My understanding is that the scheduling of the pods that use a persistent
volume should be managed by the platform (Kubernetes). As we are using a PVC
with the default storage class, it is up to the configured provisioner for the
cluster to specify node affinity for the provisioned persistent volume. Then
pods that use this PV will only be scheduled to nodes that are selected by the
node affinity.
So multi-node clusters should be using `local` volumes instead of `hostPath`
volumes. The provisioned `local` volumes should have the node affinity defined
for the node they've been provisioned on. This generalises for other kind of
storage devices.
Single-node clusters like those managed by Minikube or MiniShift can still
use `hostPath` volumes. This is what the provisioner for the default storage
class configured does actually.
In any cases, I don't think it is manageable to hard-code / handle the
scheduling in the operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
