astefanutti commented on a change in pull request #583: Split builder from
operator
URL: https://github.com/apache/camel-k/pull/583#discussion_r272461208
##########
File path: pkg/builder/kaniko/publisher.go
##########
@@ -111,6 +111,12 @@ func Publisher(ctx *builder.Context) error {
args = baseArgs
}
+ // The pod will be scheduled to nodes that are selected by the
persistent volume
Review comment:
The build pods still need to share the build output with Kaniko. And the
Kaniko warmer pod needs to share the cache as well to be effective.
I have to test on GKE, but it seems from your experience that the
provisioner for the default storage class uses `hostPath`.
In the long term, I think the affinity should be coming from the persistent
volume and the scheduling managed by the platform, to support other kind of
volumes and avoid the operator and the builds to be scheduled on a single node.
But in the short term, until we do some more testing, I suggest:
* I add the affinity constraint back
* I set the build strategy to `pod` when the `kaniko` publish strategy is set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
