The build on CI wasn't failing. I'm +1 for reverting. Il mer 14 ago 2019, 21:49 Claus Ibsen <[email protected]> ha scritto:
> Hi Babak > > We should not have camel-apt as compile dependency as its should not > be there for regular Camel end users. > > I wonder what error you see - the code before was like it was in camel > 2.x and has always been. > So I wonder what error you have. > > IMHO we need to revert so its as before, but before I wonder what > problem you had. > > On Wed, Aug 14, 2019 at 6:38 PM <[email protected]> wrote: > > > > This is an automated email from the ASF dual-hosted git repository. > > > > bvahdat pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/camel.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new 8d4834e fix the compilation error because of the missing > DefinitionPropertiesPlaceholderProviderHelper class being generated > > 8d4834e is described below > > > > commit 8d4834e0752d0b6a8b45c6df36641e3f9b5a8eaf > > Author: Babak Vahdat <[email protected]> > > AuthorDate: Wed Aug 14 18:38:15 2019 +0200 > > > > fix the compilation error because of the missing > DefinitionPropertiesPlaceholderProviderHelper class being generated > > --- > > core/camel-core/pom.xml | 23 ++++------------------- > > 1 file changed, 4 insertions(+), 19 deletions(-) > > > > diff --git a/core/camel-core/pom.xml b/core/camel-core/pom.xml > > index 118b999..b073fe1 100644 > > --- a/core/camel-core/pom.xml > > +++ b/core/camel-core/pom.xml > > @@ -65,6 +65,10 @@ > > </dependency> > > <dependency> > > <groupId>org.apache.camel</groupId> > > + <artifactId>apt</artifactId> > > + </dependency> > > + <dependency> > > + <groupId>org.apache.camel</groupId> > > <artifactId>camel-base</artifactId> > > </dependency> > > <dependency> > > @@ -637,25 +641,6 @@ > > </build> > > </profile> > > > > - <!-- enables the APT dependency so that it can be disabled in > IDE builds --> > > - <profile> > > - <id>apt</id> > > - <activation> > > - <activeByDefault>true</activeByDefault> > > - </activation> > > - > > - <dependencies> > > - > > - <!-- enable the APT processor --> > > - <dependency> > > - <groupId>org.apache.camel</groupId> > > - <artifactId>apt</artifactId> > > - <scope>provided</scope> > > - </dependency> > > - > > - </dependencies> > > - </profile> > > - > > <!-- skip management tests on AIX as it hangs CI servers --> > > <profile> > > <id>aix</id> > > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 >
