> On 14 Aug 2019, at 22:14, Babak Vahdat <[email protected]> wrote: > > Hi Claus > > Without that change I get a compilation error about the missing class > DefinitionPropertiesPlaceholderProviderHelper in camel-core. > > Could you please delete your local m2 cache and try to build the master > branch locally without this commit? > > Right now I don‘t have access to my laptop, but will try to see if I can > reproduce the problem again.
Now I reverted that commit, deleted the folder ~/.m2/repository/org/apache/camel and ran `mvn clean install -Dtest=XXX` and this is the compilation error which I get now again: [INFO] Camel :: Example :: Zipkin :: Service 2 ............ SKIPPED [INFO] Camel :: Docs ...................................... SKIPPED [INFO] Camel :: Assembly .................................. SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 02:46 min [INFO] Finished at: 2019-08-14T23:40:37+02:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project camel-core: Compilation failure [ERROR] /Users/bvahdat/dev/workspace/camel/core/camel-core/src/main/java/org/apache/camel/model/DefinitionPropertyPlaceholderConfigurer.java:[24,41] error: cannot find symbol [ERROR] symbol: class DefinitionPropertiesPlaceholderProviderHelper [ERROR] location: package org.apache.camel.model.placeholder [ERROR] [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :camel-core And I guess this missing class gets generated here: https://github.com/apache/camel/blob/master/tooling/apt/src/main/java/org/apache/camel/tools/apt/PropertyPlaceholderGenerator.java#L108-L163 <https://github.com/apache/camel/blob/master/tooling/apt/src/main/java/org/apache/camel/tools/apt/PropertyPlaceholderGenerator.java#L108-L163> Babak > > Sorry for the noise > Babak > >> Am 14.08.2019 um 21:57 schrieb Andrea Cosentino <[email protected]>: >> >> The build on CI wasn't failing. I'm +1 for reverting. >> >> Il mer 14 ago 2019, 21:49 Claus Ibsen <[email protected]> ha scritto: >> >>> Hi Babak >>> >>> We should not have camel-apt as compile dependency as its should not >>> be there for regular Camel end users. >>> >>> I wonder what error you see - the code before was like it was in camel >>> 2.x and has always been. >>> So I wonder what error you have. >>> >>> IMHO we need to revert so its as before, but before I wonder what >>> problem you had. >>> >>>> On Wed, Aug 14, 2019 at 6:38 PM <[email protected]> wrote: >>>> >>>> This is an automated email from the ASF dual-hosted git repository. >>>> >>>> bvahdat pushed a commit to branch master >>>> in repository https://gitbox.apache.org/repos/asf/camel.git >>>> >>>> >>>> The following commit(s) were added to refs/heads/master by this push: >>>> new 8d4834e fix the compilation error because of the missing >>> DefinitionPropertiesPlaceholderProviderHelper class being generated >>>> 8d4834e is described below >>>> >>>> commit 8d4834e0752d0b6a8b45c6df36641e3f9b5a8eaf >>>> Author: Babak Vahdat <[email protected]> >>>> AuthorDate: Wed Aug 14 18:38:15 2019 +0200 >>>> >>>> fix the compilation error because of the missing >>> DefinitionPropertiesPlaceholderProviderHelper class being generated >>>> --- >>>> core/camel-core/pom.xml | 23 ++++------------------- >>>> 1 file changed, 4 insertions(+), 19 deletions(-) >>>> >>>> diff --git a/core/camel-core/pom.xml b/core/camel-core/pom.xml >>>> index 118b999..b073fe1 100644 >>>> --- a/core/camel-core/pom.xml >>>> +++ b/core/camel-core/pom.xml >>>> @@ -65,6 +65,10 @@ >>>> </dependency> >>>> <dependency> >>>> <groupId>org.apache.camel</groupId> >>>> + <artifactId>apt</artifactId> >>>> + </dependency> >>>> + <dependency> >>>> + <groupId>org.apache.camel</groupId> >>>> <artifactId>camel-base</artifactId> >>>> </dependency> >>>> <dependency> >>>> @@ -637,25 +641,6 @@ >>>> </build> >>>> </profile> >>>> >>>> - <!-- enables the APT dependency so that it can be disabled in >>> IDE builds --> >>>> - <profile> >>>> - <id>apt</id> >>>> - <activation> >>>> - <activeByDefault>true</activeByDefault> >>>> - </activation> >>>> - >>>> - <dependencies> >>>> - >>>> - <!-- enable the APT processor --> >>>> - <dependency> >>>> - <groupId>org.apache.camel</groupId> >>>> - <artifactId>apt</artifactId> >>>> - <scope>provided</scope> >>>> - </dependency> >>>> - >>>> - </dependencies> >>>> - </profile> >>>> - >>>> <!-- skip management tests on AIX as it hangs CI servers --> >>>> <profile> >>>> <id>aix</id> >>>> >>> >>> >>> -- >>> Claus Ibsen >>> ----------------- >>> http://davsclaus.com @davsclaus >>> Camel in Action 2: https://www.manning.com/ibsen2 >>>
