Hi Andrea, yeah, good catch, I did that just now. As for the two binary files Justin mentioned in the camel-logback test suite, I've consulted legal[1], so let's see what their position on this is.
zoran [1] https://issues.apache.org/jira/browse/LEGAL-577 On Tue, Jun 8, 2021 at 10:48 AM Andrea Cosentino <anco...@gmail.com> wrote: > > Maybe we need to do it on 3.4.x too, because we are about to release the > last LTS. I forgot about 3.4.6 > > Il giorno mar 8 giu 2021 alle ore 10:42 Zoran Regvart <zo...@regvart.com> > ha scritto: > > > Hi Andrea, > > thanks, yes that will be needed, I've pushed to 3.7.x[1] as well. > > > > [1] > > https://github.com/apache/camel/commit/333de175f7dc072ea69c8f1515d87afc07c93c47 > > > > On Tue, Jun 8, 2021 at 9:56 AM Andrea Cosentino <anco...@gmail.com> wrote: > > > > > > Yes, I think it's fine. Maybe we need to do the same on 3.7.x because > > we'll > > > probably release again for LTS. > > > > > > Thanks for the help Zoran! > > > > > > Il giorno mar 8 giu 2021 alle ore 09:42 Zoran Regvart <zo...@regvart.com > > > > > > ha scritto: > > > > > > > Hi Justin, Andrea, Cameleers, > > > > just spinning this in a new thread. I think I found the issue why the > > > > `docs/node` is included in the release source archives. This is where > > > > the frontend-maven-plugin downloads the installation that's used to > > > > build the documentation. It's not immediately visible as this > > > > directory is ignored via .gitignore and the content of it is only > > > > created at build time. > > > > > > > > I've pushed a fix on main[1] and on 2.25.x[2]. I do think that > > > > dot-files are ignored by the assembly plugin, but out of excess of > > > > caution I've also omitted `docs/.yarn`. > > > > > > > > If need be we can discuss if this merits new releases. My opinion is > > > > that we release often enough so having this fixed for next releases of > > > > 2.25.x and 3.x, should be okay. > > > > > > > > zoran > > > > > > > > [1] > > > > > > https://github.com/apache/camel/commit/7fa38f86d5ba1efb28d26f77bf5c3c7f5070520e > > > > [2] > > > > > > https://github.com/apache/camel/commit/2fc6b0c3e742210aa7ae2a53aec8c9e7ee7d2609 > > > > -- > > > > Zoran Regvart > > > > > > > > > > > > -- > > Zoran Regvart > > -- Zoran Regvart
