Hi Ah okay the 3.22 is Java 11 as minimum version, so that javadoc plugin should be bumped to 11 instead of 8.
On Tue, Dec 19, 2023 at 11:43 AM Andrea Cosentino <anco...@gmail.com> wrote: > Looks good to me. > > Thanks Gregor. > > Il giorno mar 19 dic 2023 alle ore 11:42 Gregor Zurowski < > gre...@list.zurowski.org> ha scritto: > > > I am having the following issue when building the 3.x branch: > > > > ``` > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar > > (attach-javadocs) on project camel-api: MavenReportException: Error > > while generating Javadoc: > > [ERROR] Exit code: 1 - > > > > > /git/camel/core/camel-api/src/main/java/org/apache/camel/support/jsse/KeyStoreParameters.java:196: > > error: variables in try-with-resources are not supported in -source 8 > > [ERROR] try (is) { > > [ERROR] ^ > > [ERROR] (use -source 9 or higher to enable variables in > > try-with-resources) > > ``` > > > > It is essentially about the use of try-with-resources here: > > > > > https://github.com/apache/camel/blob/a4c5c22b3a630a5d080d293db02655962d6732ca/core/camel-api/src/main/java/org/apache/camel/support/jsse/KeyStoreParameters.java#L196 > > : > > > > It was introduced with this PR: > > https://github.com/apache/camel/pull/11317/files > > > > Note that the maven-java-doc plugin is set to Java 8 on the 3.x > > branch, although I am not sure how this plays into the problem. > > > > I have addressed it as follows: > > > > > https://github.com/apache/camel/commit/8803f11b30953da9bf46387e9fd98afa072fa06e > > > > Please let me know if you have any concerns. > > > > Thanks in advance, > > Gregor > > > > > > On Wed, Dec 13, 2023 at 9:06 AM Andrea Cosentino <anco...@gmail.com> > > wrote: > > > > > > +1, I would like to add the SBOM also to the branch, so we can publish > > it, > > > but we can do that by hand too. > > > > > > > > > > > > Il giorno mer 13 dic 2023 alle ore 08:46 Claus Ibsen < > > claus.ib...@gmail.com> > > > ha scritto: > > > > > > > Hi > > > > > > > > Okay so camel-3.x branches are ready for cutting 3.22.0 release. > > > > > > > > > > > > On Tue, Dec 12, 2023 at 5:10 PM Claus Ibsen <claus.ib...@gmail.com> > > wrote: > > > > > > > > > Hi > > > > > > > > > > We have one last release in 3.x which is the 3.22.0 release. > > > > > > > > > > This is a smaller 3.x release and is the last planned for 3.x. > Users > > on > > > > > 3.x should consider upgrading to v4, and start new development on > v4 > > if > > > > > possible. > > > > > > > > > > There are no more planned work for 3.22.0, so we can do a sanity > > check on > > > > > the branches, and then if Gregor still has time then we can > possible > > have > > > > > it released later this year. > > > > > > > > > > The plan is for 3.22.0 to be LTS until end of 2024. However we do > not > > > > > focus on 3.x anymore and this release will not come with many patch > > > > > releases. We only fix critical CVEs reported in Camel source code, > > and > > > > > other very important bug fixes. > > > > > > > > > > When we have the 3.22.0 release, then we should do a blog post > about > > the > > > > > "end of 3.x" > > > > > > > > > > > > > > > -- > > > > > Claus Ibsen > > > > > ----------------- > > > > > @davsclaus > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > -- > > > > Claus Ibsen > > > > ----------------- > > > > @davsclaus > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > -- Claus Ibsen ----------------- @davsclaus Camel in Action 2: https://www.manning.com/ibsen2