ajantha-bhat commented on a change in pull request #4132:
URL: https://github.com/apache/carbondata/pull/4132#discussion_r634252117
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortParameters.java
##########
@@ -532,7 +556,7 @@ public static SortParameters
createSortParameters(CarbonDataLoadConfiguration co
parameters.setNoDictSortDataType(noDictSortAndNoSortDataTypes.get("noDictSortDataTypes"));
parameters.setNoDictNoSortDataType(noDictSortAndNoSortDataTypes.get("noDictNoSortDataTypes"));
// keep partition columns in the end for table spec by getting
rearranged tale spec
- TableSpec tableSpec = new
TableSpec(configuration.getTableSpec().getCarbonTable(), true);
+ TableSpec tableSpec = new
TableSpec(configuration.getTableSpec().getCarbonTable(), false);
Review comment:
a) Inside TableSpec, If the true part is dead code, please remove it.
b) remove the above comments, it's not applicable anymore.
c) Please check all the test case with
`carbon.enable.bad.record.handling.for.insert` true also.
i) partition column, same sort column (all the type, measure & dim) [
local sort, global, no sort]
ii) partition column without sort columns
iii) partition with other sort columns (all the type, measure & dim) [
local sort, global, no sort]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
