[GitHub] [carbondata] nihal0107 commented on a change in pull request #4132: [CARBONDATA-4186] Fixed insert failure when partition column present in local sort scope

[GitBox]

nihal0107 commented on a change in pull request #4132:
URL: https://github.com/apache/carbondata/pull/4132#discussion_r642835796



##########
File path: 
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortParameters.java
##########
@@ -532,7 +556,7 @@ public static SortParameters 
createSortParameters(CarbonDataLoadConfiguration co
       
parameters.setNoDictSortDataType(noDictSortAndNoSortDataTypes.get("noDictSortDataTypes"));
       
parameters.setNoDictNoSortDataType(noDictSortAndNoSortDataTypes.get("noDictNoSortDataTypes"));
       // keep partition columns in the end for table spec by getting 
rearranged tale spec
-      TableSpec tableSpec = new 
TableSpec(configuration.getTableSpec().getCarbonTable(), true);
+      TableSpec tableSpec = new 
TableSpec(configuration.getTableSpec().getCarbonTable(), false);

Review comment:
       For some of the scenario test cases were already present like:
   a) partition column without sort columns
   b) partition with other sort columns (all the type, measure & dim) [ local 
sort, global, no sort]
   c) static partition and dynamic partition together
   
   and test case which I have added covered for some of flow like:
   a) partition column, same sort column (all the type, measure & dim) [ local 
sort, global, no sort]
   b) more than one partition column (one int, one string) and more than one 
sort column for above scenarios.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org