akashrn5 commented on a change in pull request #4148:
URL: https://github.com/apache/carbondata/pull/4148#discussion_r677287243
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/CarbonSession.scala
##########
@@ -293,5 +293,10 @@ object CarbonSession {
def merge(srcDS: Dataset[Row], expr: Column): MergeDataSetBuilder = {
new MergeDataSetBuilder(ds, srcDS, expr, ds.sparkSession)
}
+
+ def merge(srcDS: Dataset[Row], keyColumn: String, operationType: String):
UpsertBuilder = {
Review comment:
ok, for the user exposed APIs, I will change to update, delete, upsert
and insert. Internally we can call this merge method and make this private and
keep other code same for better code handling. This is because internally we
need to call the merge command class itself, so I thought we can do it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
