kunal642 commented on a change in pull request #4148:
URL: https://github.com/apache/carbondata/pull/4148#discussion_r677995169
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockIndex.java
##########
@@ -886,16 +888,7 @@ public String getTableTaskInfo(int index) {
}
}
- private byte[][] getMinMaxValue(IndexRow row, int index) {
- IndexRow minMaxRow = row.getRow(index);
- byte[][] minMax = new byte[minMaxRow.getColumnCount()][];
- for (int i = 0; i < minMax.length; i++) {
- minMax[i] = minMaxRow.getByteArray(i);
- }
- return minMax;
- }
-
- private boolean[] getMinMaxFlag(IndexRow row, int index) {
+ private static boolean[] getMinMaxFlag(IndexRow row, int index) {
Review comment:
is static needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
