kunal642 commented on a change in pull request #4189:
URL: https://github.com/apache/carbondata/pull/4189#discussion_r686934382
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
##########
@@ -601,4 +599,60 @@ public String getSegmentIdFromFilePath(String filePath) {
}
return CarbonCommonConstants.INVALID_SEGMENT_ID;
}
+
+ /**
+ * return valid segment to access
+ * first check for mapreduce.input.carboninputformat.segmentnumbers"
+ * second check for table property of latest_segment for query
+ */
+ public Segment[] getSegmentsToAccess(JobContext job, ReadCommittedScope
readCommittedScope,
+ List<Segment> validSegments) {
+ String segmentString = job.getConfiguration().get(INPUT_SEGMENT_NUMBERS,
"");
Review comment:
call getSegmentsToAccess(JobContext job, ReadCommittedScope
readCommittedScope) to get the segments set in configuration, instead of
writing the code again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
