MarvinLitt commented on pull request #4189: URL: https://github.com/apache/carbondata/pull/4189#issuecomment-897290223
> * the new csv is not needed as we already have several csv in our resources, use any one of the existing one(this is not needed if point 2 is done) > * better to use insert instead of load and no need for filter condition, just use select * because this is not related to any filter. > * I can see only 2-3 conditions in your test cases, better to add them in a existing test suite, please avoid creating new test files unless absolutely necessary 1. to use load command in test case because there are many scenarios for using load, hope to take care of this command in the test case. 2. new csv file is because latest-table-data.csv is not same with the old one. I removed some values from some columns， to check whether the latest segment is right or not. 3. yes, of couse the test case can move to an exists test case file, if need i will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
