ShreelekhyaG commented on code in PR #4257:
URL: https://github.com/apache/carbondata/pull/4257#discussion_r845739406
##########
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala:
##########
@@ -143,9 +143,24 @@ case class CarbonCreateMVCommand(
tableIdentifier: TableIdentifier,
viewManager: MVManagerInSpark,
viewCatalog: MVCatalogInSpark): MVSchema = {
- val logicalPlan = MVHelper.dropDummyFunction(
+ var logicalPlan = MVHelper.dropDummyFunction(
MVQueryParser.getQueryPlan(queryString, session))
- // check if mv with same query already exists
+ val relatedTables = getRelatedTables(logicalPlan)
+ val viewRefreshMode = if (checkIsQueryNeedFullRefresh(logicalPlan) ||
+ checkIsHasNonCarbonTable(relatedTables)) {
+ MVProperty.REFRESH_MODE_FULL
+ } else {
+ MVProperty.REFRESH_MODE_INCREMENTAL
+ }
+ var modifiedQueryString = queryString
+ if (viewRefreshMode.equalsIgnoreCase(MVProperty.REFRESH_MODE_INCREMENTAL)
&&
+ queryString.toLowerCase.contains(CarbonCommonConstants.AVERAGE)) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
