ShreelekhyaG commented on code in PR #4257:
URL: https://github.com/apache/carbondata/pull/4257#discussion_r847150023
##########
integration/spark/src/main/scala/org/apache/carbondata/view/MVCatalogInSpark.scala:
##########
@@ -172,7 +188,7 @@ case class MVCatalogInSpark(session: SparkSession)
val modularPlan = SimpleModularizer.modularize(
BirdcageOptimizer.execute(logicalPlan)).next().semiHarmonized
val signature = modularPlan.signature
- viewSchemas += MVSchemaWrapper(signature, null, logicalPlan, null)
+ viewSchemas += MVSchemaWrapper(signature, null, logicalPlan,
logicalPlan, null)
Review Comment:
This API is used for test only and is called in some test suites where
`modifiedLogicalPlan `doesn't matter. In the main API to register schema at
`Line No: 157`, `modifiedLogicalPlan `is sent.
##########
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala:
##########
@@ -139,13 +139,42 @@ case class CarbonCreateMVCommand(
override protected def opName: String = "CREATE MATERIALIZED VIEW"
+ def checkIfAvgAggregatePresent(logicalPlan: LogicalPlan): Boolean = {
+ if (logicalPlan.isInstanceOf[Aggregate]) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
