[
https://issues.apache.org/jira/browse/CARBONDATA-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358966#comment-15358966
]
ASF GitHub Bot commented on CARBONDATA-30:
------------------------------------------
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/8#discussion_r69298991
--- Diff:
core/src/main/java/org/carbondata/core/util/CarbonTimeStatisticsFactory.java ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.carbondata.core.util;
+
+import org.carbondata.core.constants.CarbonCommonConstants;
+
+public class CarbonTimeStatisticsFactory {
+ private static String timeStatisticsUtilType;
+
+ static {
+ CarbonTimeStatisticsFactory.updateTimeStatisticsUtilStatus();
+ }
+
+ private static void updateTimeStatisticsUtilStatus() {
+ timeStatisticsUtilType = CarbonProperties.getInstance()
+ .getProperty(CarbonCommonConstants.TIME_STAT_OPEN,
+ CarbonCommonConstants.TIME_STAT_OPEN_DEFAULT);
+ }
+
+ public static AbstractTimeStatisticsUtil getTimeStatisticsUtil() {
+ switch (timeStatisticsUtilType.toLowerCase()) {
--- End diff --
No need to check every time. You can create instance in static block
> Record load performance statistics
> ----------------------------------
>
> Key: CARBONDATA-30
> URL: https://issues.apache.org/jira/browse/CARBONDATA-30
> Project: CarbonData
> Issue Type: New Feature
> Reporter: zhangshunyu
> Assignee: zhangshunyu
>
> We should use a parameter which can be configured by user to determine
> whether the statistics will be recorded and calculated during data loading.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
