[
https://issues.apache.org/jira/browse/CARBONDATA-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358976#comment-15358976
]
ASF GitHub Bot commented on CARBONDATA-30:
------------------------------------------
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/8#discussion_r69300280
--- Diff:
core/src/main/java/org/carbondata/core/util/CarbonTimeStatisticsUtil.java ---
@@ -0,0 +1,362 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.carbondata.core.util;
+
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.carbondata.common.logging.LogService;
+import org.carbondata.common.logging.LogServiceFactory;
+
+/**
+ * A util which provide methods used to record time information druing
data loading.
+ */
+public class CarbonTimeStatisticsUtil implements
AbstractTimeStatisticsUtil {
--- End diff --
class name which has `util` is confusing, since we use only static and
utility methods used in util classes. Better remove `util` from class name. And
also these statistics are only for loading data so class name should reflect
that.
> Record load performance statistics
> ----------------------------------
>
> Key: CARBONDATA-30
> URL: https://issues.apache.org/jira/browse/CARBONDATA-30
> Project: CarbonData
> Issue Type: New Feature
> Reporter: zhangshunyu
> Assignee: zhangshunyu
>
> We should use a parameter which can be configured by user to determine
> whether the statistics will be recorded and calculated during data loading.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
