[
https://issues.apache.org/jira/browse/CARBONDATA-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359261#comment-15359261
]
ASF GitHub Bot commented on CARBONDATA-31:
------------------------------------------
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/11#discussion_r69327649
--- Diff:
integration/spark/src/main/scala/org/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -93,11 +93,11 @@ object CarbonDataRDDFactory extends Logging {
}
def mergeCarbonData(
- sc: SQLContext,
- carbonLoadModel: CarbonLoadModel,
- storeLocation: String,
- hdfsStoreLocation: String,
- partitioner: Partitioner) {
+ sqlContext: SQLContext,
--- End diff --
Please don't change the format.
> Unify definition for SparkContext,CarbonContext,HiveContext,SQLContext
> ----------------------------------------------------------------------
>
> Key: CARBONDATA-31
> URL: https://issues.apache.org/jira/browse/CARBONDATA-31
> Project: CarbonData
> Issue Type: Improvement
> Reporter: ChenLiang
> Assignee: ChenLiang
> Priority: Minor
>
> For SparkContext,CarbonContext,HiveContext,SQLContext definition, different
> places having different definition, for example:
> 1)val sc = new CaronContext, val carboncontext = new CaronContext
> 2)var oc: HiveContext , var context: HiveContext
> ....
> To unify definition for SparkContext,CarbonContext,HiveContext,SQLContext as
> below:
> CarbonContext : cc
> SQLContext : sqlContext
> SparkContext : sc
> HiveContext : hiveContext
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
