[
https://issues.apache.org/jira/browse/CARBONDATA-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360185#comment-15360185
]
ASF GitHub Bot commented on CARBONDATA-31:
------------------------------------------
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/14#discussion_r69378261
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonMetastoreCatalog.scala
---
@@ -101,8 +101,8 @@ case class DictionaryMap(dictionaryMap: Map[String,
Boolean]) {
}
}
-class CarbonMetastoreCatalog(hive: HiveContext, val storePath: String,
client: ClientInterface)
- extends HiveMetastoreCatalog(client, hive)
+class CarbonMetastoreCatalog(hiveContext: HiveContext, val storePath:
String, client: ClientInterface)
+ extends HiveMetastoreCatalog(client, hiveContext)
--- End diff --
check style is failing here. Please do `mvn scalastyle:check` and `mvn
checkstyle:check`
> Unify definition for SparkContext,CarbonContext,HiveContext,SQLContext
> ----------------------------------------------------------------------
>
> Key: CARBONDATA-31
> URL: https://issues.apache.org/jira/browse/CARBONDATA-31
> Project: CarbonData
> Issue Type: Improvement
> Reporter: ChenLiang
> Assignee: ChenLiang
> Priority: Minor
>
> For SparkContext,CarbonContext,HiveContext,SQLContext definition, different
> places having different definition, for example:
> 1)val sc = new CaronContext, val carboncontext = new CaronContext
> 2)var oc: HiveContext , var context: HiveContext
> ....
> To unify definition for SparkContext,CarbonContext,HiveContext,SQLContext as
> below:
> CarbonContext : cc
> SQLContext : sqlContext
> SparkContext : sc
> HiveContext : hiveContext
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
