[
https://issues.apache.org/jira/browse/CARBONDATA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360040#comment-15360040
]
ASF GitHub Bot commented on CARBONDATA-32:
------------------------------------------
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/12#discussion_r69374128
--- Diff:
integration/spark/src/main/scala/org/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -67,16 +65,15 @@ object CarbonScalaUtil {
}
}
- def convertCarbonToSparkDataType(dataType: DataType): types.DataType = {
+ def convertCarbonToSparkDataType(dataType: CarbonDataType):
types.DataType = {
dataType match {
- case DataType.STRING => StringType
- case DataType.SHORT => ShortType
- case DataType.INT => IntegerType
- case DataType.LONG => LongType
- case DataType.DOUBLE => DoubleType
- case DataType.BOOLEAN => BooleanType
- case DataType.DECIMAL => DecimalType.SYSTEM_DEFAULT
- case DataType.TIMESTAMP => TimestampType
+ case CarbonDataType.STRING => StringType
+ case CarbonDataType.INT => IntegerType
--- End diff --
`ShortType` is missing
> Refactor DataType related code
> ------------------------------
>
> Key: CARBONDATA-32
> URL: https://issues.apache.org/jira/browse/CARBONDATA-32
> Project: CarbonData
> Issue Type: Bug
> Reporter: Jacky Li
> Priority: Minor
>
> 1. Merge two DataType
> 2. Merge tow DataTypeUtil
> 3. Remove DataSetUtil
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
