[
https://issues.apache.org/jira/browse/CARBONDATA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360041#comment-15360041
]
ASF GitHub Bot commented on CARBONDATA-32:
------------------------------------------
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/12#discussion_r69374134
--- Diff:
integration/spark/src/main/scala/org/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -24,29 +24,27 @@ import org.apache.spark.sql.execution.command.Level
import org.apache.spark.sql.hive.{CarbonMetaData, DictionaryMap}
import org.apache.spark.sql.types._
-import org.carbondata.core.carbon.metadata.datatype.DataType
+import org.carbondata.core.carbon.metadata.datatype.{DataType =>
CarbonDataType}
import org.carbondata.core.carbon.metadata.encoder.Encoding
import org.carbondata.core.carbon.metadata.schema.table.CarbonTable
import org.carbondata.core.constants.CarbonCommonConstants
-import org.carbondata.scan.expression.{DataType => CarbonDataType}
object CarbonScalaUtil {
def convertSparkToCarbonDataType(
dataType: org.apache.spark.sql.types.DataType): CarbonDataType = {
dataType match {
- case StringType => CarbonDataType.StringType
- case ShortType => CarbonDataType.ShortType
- case IntegerType => CarbonDataType.IntegerType
- case LongType => CarbonDataType.LongType
- case DoubleType => CarbonDataType.DoubleType
- case FloatType => CarbonDataType.FloatType
- case DateType => CarbonDataType.DateType
- case BooleanType => CarbonDataType.BooleanType
- case TimestampType => CarbonDataType.TimestampType
- case ArrayType(_, _) => CarbonDataType.ArrayType
- case StructType(_) => CarbonDataType.StructType
- case NullType => CarbonDataType.NullType
- case _ => CarbonDataType.DecimalType
+ case StringType => CarbonDataType.STRING
+ case IntegerType => CarbonDataType.INT
--- End diff --
`ShortType` is missing
> Refactor DataType related code
> ------------------------------
>
> Key: CARBONDATA-32
> URL: https://issues.apache.org/jira/browse/CARBONDATA-32
> Project: CarbonData
> Issue Type: Bug
> Reporter: Jacky Li
> Priority: Minor
>
> 1. Merge two DataType
> 2. Merge tow DataTypeUtil
> 3. Remove DataSetUtil
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
