[
https://issues.apache.org/jira/browse/CARBONDATA-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414952#comment-15414952
]
ASF GitHub Bot commented on CARBONDATA-155:
-------------------------------------------
GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/incubator-carbondata/pull/71
CARBONDATA-155 Code refactor to avoid the Type Casting in compareTo method
…
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata
code_refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 0683c850579b4852b100cca6cd311d3c90062213
Author: mohammadshahidkhan <[email protected]>
Date: 2016-08-10T08:57:17Z
CARBONDATA-155 Code refactor to avoid the Type Casting in compareTo method
----
> Code refactor to avoid the Type Casting in compareTo method
> -----------------------------------------------------------
>
> Key: CARBONDATA-155
> URL: https://issues.apache.org/jira/browse/CARBONDATA-155
> Project: CarbonData
> Issue Type: Bug
> Reporter: Mohammad Shahid Khan
>
> PraveenAdlakha added a note 23 hours ago
> Hi ,
> Would like to suggest a couple of things here remove Comparable from the
> class definition as Distributable is already implementing it.
> Let use generics so that we donot have to typeCast everywhere in the compare
> method for that need to do two things:
> 1) Change the class definition of Distributable to :
> public abstract class Distributable> implements Comparable
> 2) Change the compareTo method definition to:
> public int compareTo(TableBlockInfo other)
> Let me know incase you are facing any isssue in doing this I will provide the
> patch if needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
