[
https://issues.apache.org/jira/browse/CARBONDATA-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415030#comment-15415030
]
ASF GitHub Bot commented on CARBONDATA-155:
-------------------------------------------
Github user PraveenAdlakha commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/71#discussion_r74214738
--- Diff:
core/src/main/java/org/carbondata/core/carbon/datastore/block/Distributable.java
---
@@ -19,7 +19,7 @@
/**
* Abstract class which is maintains the locations of node.
*/
-public abstract class Distributable implements Comparable<Distributable> {
+public abstract class Distributable<T> implements Comparable<T> {
--- End diff --
having T extends Distributable will make better as we can limit the usage
to the classes which are extending Distributable
> Code refactor to avoid the Type Casting in compareTo method
> -----------------------------------------------------------
>
> Key: CARBONDATA-155
> URL: https://issues.apache.org/jira/browse/CARBONDATA-155
> Project: CarbonData
> Issue Type: Bug
> Reporter: Mohammad Shahid Khan
> Assignee: Mohammad Shahid Khan
>
> PraveenAdlakha added a note 23 hours ago
> Hi ,
> Would like to suggest a couple of things here remove Comparable from the
> class definition as Distributable is already implementing it.
> Let use generics so that we donot have to typeCast everywhere in the compare
> method for that need to do two things:
> 1) Change the class definition of Distributable to :
> public abstract class Distributable> implements Comparable
> 2) Change the compareTo method definition to:
> public int compareTo(TableBlockInfo other)
> Let me know incase you are facing any isssue in doing this I will provide the
> patch if needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
