Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/203#discussion_r80900701
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonOption.scala
---
@@ -17,13 +17,15 @@
package org.apache.carbondata.spark
+import org.apache.spark.sql.{getDB, SQLContext}
+
/**
* Contains all options for Spark data source
*/
-class CarbonOption(options: Map[String, String]) {
+class CarbonOption(options: Map[String, String], cc: SQLContext) {
def tableIdentifier: String = options.getOrElse("tableName",
s"$dbName.$tableName")
- def dbName: String = options.getOrElse("dbName", "default")
+ def dbName: String = getDB.getDatabaseName(options.get("dbName"), cc)
--- End diff --
Is this modification required for this PR?
It is better not adding cc into CarbonOption which will restrict its usage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
