Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/203#discussion_r80932289
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
@@ -742,7 +742,8 @@ object GlobalDictionaryUtil extends Logging {
*/
def generateGlobalDictionary(sqlContext: SQLContext,
carbonLoadModel: CarbonLoadModel,
- hdfsLocation: String): Unit = {
+ hdfsLocation: String,
+ dataFrame: Option[DataFrame] = None): Unit
= {
--- End diff --
I think we can call dataFrame.rdd.cache inside this function, because there
are 2 scan, dataframe can be re-used after the first scan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
