Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/203#discussion_r82369947
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataLoadRDD.scala
---
@@ -72,8 +76,91 @@ class CarbonNodePartition(rddId: Int, val idx: Int,
host: String,
override def hashCode(): Int = 41 * (41 + rddId) + idx
}
+object CarbonDataLoadRDDFuncs extends Logging{
--- End diff --
Can we have a more meaningful name for this?
I suggest `SparkPartitionLoader` (it loads one spark partition into carbon
using kettle), and make it a class instead of object, so that it can keep the
storeLocation internally instead of returning it in initialize function. One is
using the returned storeLocation variable other than run function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
