Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/230#discussion_r83349683
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
 ---
    @@ -252,6 +252,15 @@ private static long getMaxOfBlockAndFileSize(long 
blockSize, long fileSize) {
         if (remainder > 0) {
           maxSize = maxSize + HDFS_CHECKSUM_LENGTH - remainder;
         }
    +    long setBlockSizeInMb = blockSize / 
CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR /
    +            CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR;
    +    // actual file size may be less than 1KB or 1MB, need to classify.
    +    String readableFileSize = ByteUtil.convertByteToReadable(fileSize);
    +    long maxSizeInMb = maxSize / 
CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR /
    +            CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR;
    +    LOGGER.info("The configured block size is " + setBlockSizeInMb + " MB, 
" +
    --- End diff --
    
    Use the new function here to format readable 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to