Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/230#discussion_r83361557
  
    --- Diff: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
 ---
    @@ -1422,6 +1422,7 @@ private[sql] case class DescribeCommandFormatted(
         results ++= Seq(("Table Name : ", 
relation.tableMeta.carbonTableIdentifier.getTableName, ""))
         results ++= Seq(("CARBON Store Path : ", relation.tableMeta.storePath, 
""))
         val carbonTable = relation.tableMeta.carbonTable
    +    results ++= Seq(("Table Block Size : ", carbonTable.getBlocksize + " 
MB", ""))
    --- End diff --
    
    If so, can you change the corresponding variable name and function name to 
indicate it is bytes in MB,  like `getBlockSizeInMB` and  add comment to 
`CarbonCommonConstants.TABLE_BLOCKSIZE`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to