Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/229#discussion_r83354231
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java
 ---
    @@ -73,15 +72,15 @@ public 
AbstractDataLoadProcessorStep(CarbonDataLoadConfiguration configuration,
        * Create the iterator using child iterator.
        *
        * @param childIter
    -   * @return
    +   * @return new iterator with step specific processing.
        */
    -  protected Iterator<Object[]> getIterator(final Iterator<Object[]> 
childIter) {
    -    return new CarbonIterator<Object[]>() {
    +  protected Iterator<CarbonRow> getIterator(final Iterator<CarbonRow> 
childIter) {
    --- End diff --
    
    In order to support batch conversion, it is better to put 
`Iterator<CarbonRow[]>` instead


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to