Github user jackylk commented on a diff in the pull request:
    --- Diff: 
    @@ -55,14 +54,14 @@ public 
AbstractDataLoadProcessorStep(CarbonDataLoadConfiguration configuration,
       public abstract void intialize() throws CarbonDataLoadingException;
    -   * Tranform the data as per the implemetation.
    +   * Tranform the data as per the implementation.
        * @return Array of Iterator with data. It can be processed parallel if 
implementation class wants
        * @throws CarbonDataLoadingException
    -  public Iterator<Object[]>[] execute() throws CarbonDataLoadingException {
    -    Iterator<Object[]>[] childIters = child.execute();
    -    Iterator<Object[]>[] iterators = new Iterator[childIters.length];
    +  public Iterator<CarbonRow>[] execute() throws CarbonDataLoadingException 
    +    Iterator<CarbonRow>[] childIters = child.execute();
    +    Iterator<CarbonRow>[] iterators = new Iterator[childIters.length];
    --- End diff --
    In order to support batch conversion, it is better to put 
`Iterator<CarbonRow[]>[]` instead

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to