Agree. Regards JB
On Oct 25, 2016, 10:47, at 10:47, Liang Chen <[email protected]> wrote: >Hi > >Yes, This solution is better by providing only the jar dependency of >thrift generated jar from repo. > >Regards >Liang > > >ravipesala wrote >> Hi David, >> >> I guess keeping the generated code in apache github may not be a good >> solution, even I am not sure whether it is acceptable to keep >generated >> code in apache. >> >> I prefer to decouple the thrift code compilation from main build and >> provide separate profile to do thrift compilation and upload the jar >to >> repository. And in the main build we provide only the jar dependency >of >> thrift generated jar from repo. If anybody wants to change the >thrift >> format code then he can compile thrift format code by using separate >maven >> profile and upload the jar to snapshot repo. >> >> >> Thanks, >> Ravi. >> >> On 24 October 2016 at 14:09, Liang Chen < > >> chenliang6136@ > >> > wrote: >> >>> Hi >>> >>> I prefer to the new solution for fixing thrift issues:Directly use >java >>> code >>> ( thrift compiler compile carbondata format files to java code) to >>> build, >>> then users don't need to do any thrift installation. >>> >>> +1 for new solution. >>> >>> Regards >>> Liang >>> >>> QiangCai wrote >>> > Hi >>> > >>> > Currently, There are two typical Thrift issues: >>> > >>> > 1.Users want to directly build Apache CarbonData, don’t need to >install >>> > Thrift in advance. For example: >>> > >>> > Julian Hyde-3’s feedback in IPMC mailing list: I was not able to >build >>> > (not your fault - I did not have thrift >>> > installed and didn't have the time & patience to install it). >>> > >>> > 2.Need to fix Apache Jenkins CI issues, as below: >>> > >>> > [ERROR] Failed to execute goal >>> > org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile >>> > (generate-thrift-java) on project carbondata-format: thrift did >not >>> exit >>> > cleanly. Review output for more information. -> [Help 1] >>> > >>> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to >>> execute >>> > goal org.apache.thrift.tools:maven-thrift-plugin:0.1.11:compile >>> > (generate-thrift-java) on project carbondata-format: thrift did >not >>> exit >>> > cleanly. Review output for more information. >>> > >>> > For solving the above mentioned Thrift issues, i would like to >propose >>> one >>> > solution: Directly use java code ( thrift compiler compile >carbondata >>> > format files to java code) to build, then users don't need to do >any >>> > thrift installation. >>> > >>> > please vote and comment : >>> > >>> > To continue use the current manual install method to build >>> > >>> > or >>> > >>> > To directly use java code which be generated by thrift compiler to >>> build >>> >>> >>> >>> >>> >>> -- >>> View this message in context: http://apache-carbondata- >>> mailing-list-archive.1130556.n5.nabble.com/please-vote-and- >>> comment-remove-thrift-solution-tp2253p2254.html >>> Sent from the Apache CarbonData Mailing List archive mailing list >archive >>> at Nabble.com. >>> >> >> >> >> -- >> Thanks & Regards, >> Ravi > > > > > >-- >View this message in context: >http://apache-carbondata-mailing-list-archive.1130556.n5.nabble.com/please-vote-and-comment-remove-thrift-solution-tp2253p2284.html >Sent from the Apache CarbonData Mailing List archive mailing list >archive at Nabble.com.
