Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/262#discussion_r87712366
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -130,41 +130,27 @@ public static CarbonTable
getCarbonTable(Configuration configuration) throws IOE
return (CarbonTable)
ObjectSerializationUtil.convertStringToObject(carbonTableStr);
}
- /**
- * It sets unresolved filter expression.
- *
- * @param configuration
- * @param filterExpression
- */
- public static void setFilterPredicates(Configuration configuration,
Expression filterExpression) {
- try {
- String filterString =
ObjectSerializationUtil.convertObjectToString(filterExpression);
- configuration.set(FILTER_PREDICATE, filterString);
- } catch (Exception e) {
- throw new RuntimeException("Error while setting filter expression to
Job", e);
- }
+ public static void setTablePath(Configuration configuration, String
tablePath)
+ throws IOException {
+ configuration.set(FileInputFormat.INPUT_DIR, tablePath);
}
/**
- * It sets the resolved filter expression
+ * It sets unresolved filter expression.
*
* @param configuration
* @param filterExpression
*/
- public static void setFilterPredicates(Configuration configuration,
- FilterResolverIntf filterExpression) {
+ public static void setFilterPredicates(Configuration configuration,
Expression filterExpression) {
--- End diff --
Can't the `filterExpression` null in any case? Don't require null check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
