Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/262#discussion_r87712886
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -224,42 +221,29 @@ private void addSegmentsIfEmpty(JobContext job,
AbsoluteTableIdentifier absolute
* @return List<InputSplit> list of CarbonInputSplit
* @throws IOException
*/
- @Override public List<InputSplit> getSplits(JobContext job) throws
IOException {
- try {
+ @Override
+ public List<InputSplit> getSplits(JobContext job) throws IOException {
+ AbsoluteTableIdentifier identifier =
getAbsoluteTableIdentifier(job.getConfiguration());
+ addSegmentsIfEmpty(job, identifier);
+ if (getSegmentsToAccess(job).length == 0) {
+ return new ArrayList<>(0);
+ }
+
+ FilterResolverIntf filterInterface;
+ Expression filter = getFilterPredicates(job.getConfiguration());
+ if (filter == null) {
--- End diff --
No need of this check. Please initialize `FilterResolverIntf
filterInterface = null` at first
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
