As an aside, C* for some reason heavily uses asserts in unit tests, which adds to the "can't see the forest for the trees" problem. I see no reason for that. they should all be moved over to junit asserts.

On 09/22/2016 03:52 AM, Benjamin Lerer wrote:
We can spend hours arguing about assert vs exceptions. I have seen it
happen in every company I worked for.
Overall, based on the patches I have reviewed, it seems to me that in
general people are using them only has internal safety checks.
Unfortunatly, the code change and we can miss things.
If anybody think that some SPECIFIC assertions should be replaced by some
real checks, I think the best way to do it is to open a JIRA ticket to
raise the problem.

Reply via email to