Yes obviously we do not need to go in and replace them all at once. Some rough guidance/general consensus should be in place, because we are violating the standard usage:
https://docs.oracle.com/javase/8/docs/technotes/guides/language/assert.html Do *not* use assertions for argument checking in public methods. Do *not* use assertions to do any work that your application requires for correct operation. There should be a rational as to why and when this is right. Otherwise changes like this might be considered bikeshedding. In any case I created https://issues.apache.org/jira/browse/CASSANDRA-12688 since I think we can all agree that can not run without them at the moment and we do not want to give someone an incentive to set this off which I feel the claim of 5% performance does. On Thu, Sep 22, 2016 at 7:29 AM, Benjamin Lerer <benjamin.le...@datastax.com > wrote: > I fully agree. > > On Thu, Sep 22, 2016 at 11:57 AM, Dave Brosius <dbros...@mebigfatguy.com> > wrote: > > > As an aside, C* for some reason heavily uses asserts in unit tests, which > > adds to the "can't see the forest for the trees" problem. I see no reason > > for that. they should all be moved over to junit asserts. > > > > > > > > On 09/22/2016 03:52 AM, Benjamin Lerer wrote: > > > >> We can spend hours arguing about assert vs exceptions. I have seen it > >> happen in every company I worked for. > >> Overall, based on the patches I have reviewed, it seems to me that in > >> general people are using them only has internal safety checks. > >> Unfortunatly, the code change and we can miss things. > >> If anybody think that some SPECIFIC assertions should be replaced by > some > >> real checks, I think the best way to do it is to open a JIRA ticket to > >> raise the problem. > >> > >> > > >
