I am +1 on upgrading to latest Guava, given that we would be on 4.0 for a while, and we would have a relatively big testing phase that follows the freeze date, which would hopefully iron out (as much as possible) any issues we may have with the upgrade.
I gave a shot at upgrading to Guava 26.0; resolved build issues; about 63 Unit Tests fail - a lot of them due to a NPE and another bunch due to the driver using a method that does not exist in latest Guava. Github Branch: https://github.com/sumanth-pasupuleti/cassandra/tree/guava_26_trunk Failing Unit Tests: https://circleci.com/gh/sumanth-pasupuleti/cassandra/84 Thanks, Sumanth On Thu, Aug 16, 2018 at 8:22 AM, Jonathan Haddad <j...@jonhaddad.com> wrote: > Pushing it back means it’s a bigger risk later on. I’m +.5 on upgrading now > > On Wed, Aug 15, 2018 at 11:46 PM dinesh.jo...@yahoo.com.INVALID > <dinesh.jo...@yahoo.com.invalid> wrote: > > > Jason, > > Given that we're so close to the 9/1 date, I would err on the side of > > caution especially given the low value prop. If someone does run into > Guava > > compatibility issues (and someone somewhere will), we can revisit this > > question then. > > Dinesh > > > > On Wednesday, August 15, 2018, 11:42:31 PM PDT, Dinesh A. Joshi < > > dinesh.jo...@gatech.edu> wrote: > > > > Jason, > > Given that we're so close to the 9/1 date, I would err on the side of > > caution especially given the low value prop. If someone does run into > Guava > > compatibility issues (and someone somewhere will), we can revisit this > > question then. > > Dinesh > > > > On Wednesday, August 15, 2018, 8:22:28 AM PDT, Salih Gedik < > > m...@salih.xyz> wrote: > > > > Hi, > > > > Change logs are on Github releases page. It seems like only hash flooding > > protection which is added to ImmutableMap is relevant to Cassandra code. > I > > haven’t checked whether we use deprecated APIs. But there isn’t much on > > table from what I see. > > > > Salih > > On 15 Aug 2018 17:55 +0300, Ariel Weisberg <ar...@weisberg.ws>, wrote: > > > Hi, > > > > > > They don't even do release notes after 23. Also no API diffs. I mean > I'm > > fine with it, but it's mostly just changing to another arbitrary version > > that won't match what is in apps. > > > > > > Ariel > > > > > > On Wed, Aug 15, 2018, at 10:48 AM, Jason Brown wrote: > > > > Hey Ariel, > > > > > > > > Tbqh, not that much. I was mostly thinking from the "I have conflicts > > on > > > > guava versions in my app because I pull in cassandra and XYZ > > libraries, and > > > > the transitive dependencies on guava use different versions" POV. > > Further, > > > > we'll be on this version of guava for 4.0 for at least two years from > > now. > > > > > > > > As I asked, "does anybody feeling strongly?". Personally, I'm sorta > +0 > > to > > > > +0.5, but I was just throwing this out there in case someone does > > really > > > > think it best we upgrade (and wants to make a contribution). > > > > > > > > -Jason > > > > > > > > > > > > > > > > > > > > On Wed, Aug 15, 2018 at 7:25 AM, Ariel Weisberg <ar...@weisberg.ws> > > wrote: > > > > > > > > > Hi, > > > > > > > > > > What do we get from Guava in exchange for upgrading? > > > > > > > > > > Ariel > > > > > > > > > > On Wed, Aug 15, 2018, at 10:19 AM, Jason Brown wrote: > > > > > > Hey all, > > > > > > > > > > > > Does anyone feel strongly about upgrading guava on trunk before > > the 9/1 > > > > > > feature freeze for 4.0? We are currently at 23.3 (thanks to > > > > > > CASSANDRA-13997), and the current is 26.0. > > > > > > > > > > > > I took a quick look, and there's about 17 compilation errors. > They > > fall > > > > > > into two categories, both of which appear not too difficult to > > resolve (I > > > > > > didn't look too closely, tbh). > > > > > > > > > > > > If anyone wants to tackle this LHF I can rustle up some review > > time. > > > > > > > > > > > > Thanks, > > > > > > > > > > > > -Jason > > > > > > > > > > ------------------------------------------------------------ > --------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > -- > Jon Haddad > http://www.rustyrazorblade.com > twitter: rustyrazorblade >
