Thanks to Andy for suggestions on working around the issues, I now have build and UTs passing with Guava 26, and driver 3.6.0. Not sure if we can accommodate this in 4.0 since this is yet to be reviewed and includes quite a few changes. Updated https://issues.apache.org/jira/browse/CASSANDRA-14655 with the Github branch and CircleCI details.
Thanks, Sumanth On Fri, Aug 17, 2018 at 2:32 PM Sumanth Pasupuleti <spasupul...@netflix.com.invalid> wrote: > Thanks for the confirmation Andy. > > Created a JIRA to track the guava upgrade > https://issues.apache.org/jira/browse/CASSANDRA-14655. > > I current put target version as 4.x. If a compatible version of the driver > happens to be released soon enough, and if there is a consensus that we > should merge this into 4.0, will change the target version accordingly. > Otherwise, it seems unlikely for 4.0 purely from dependencies perspective. > > Thanks, > Sumanth > > On Thu, Aug 16, 2018 at 6:47 PM, Andy Tolbert <andrew.tolb...@datastax.com > > > wrote: > > > Hi Sumanth, > > > > I gave a shot at upgrading to Guava 26.0; resolved build issues; about 63 > > > Unit Tests fail - a lot of them due to a NPE and another bunch due to > > > the driver using a method that does not exist in latest Guava. > > > > > > > Unfortunately the driver doesn't currently work with Guava 26.0. We > have a > > fix (JAVA-1928 <https://datastax-oss.atlassian.net/browse/JAVA-1928>) > that > > addresses this that will be in version 3.6.0 which should be released in > > the coming weeks. After that the driver will work with Guava 16.0.1 > > through 26 (We've run our full test suite against all versions in that > > range). > > > > Thanks, > > Andy > > > > On Thu, Aug 16, 2018 at 6:55 PM, Sumanth Pasupuleti < > > sumanth.pasupuleti...@gmail.com> wrote: > > > > > I am +1 on upgrading to latest Guava, given that we would be on 4.0 > for a > > > while, and we would have a relatively big testing phase that follows > the > > > freeze date, which would hopefully iron out (as much as possible) any > > > issues we may have with the upgrade. > > > > > > I gave a shot at upgrading to Guava 26.0; resolved build issues; about > 63 > > > Unit Tests fail - a lot of them due to a NPE and another bunch due to > > > the driver using a method that does not exist in latest Guava. > > > > > > Github Branch: > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github. > > > com_sumanth-2Dpasupuleti_cassandra_tree_guava-5F26-5Ftrunk&d=DwIFaQ&c= > > > adz96Xi0w1RHqtPMowiL2g&r=VHsWqsWT2MoX5jRZ0xZfdAWZxBsrn5KzowynGYCJaXE&m= > > > NBUK9LYIuBLTb2_dn7ZZnfqkFQuWmAr69kTsiLgthN8&s= > > > upEwsGydoKbFV9vnRLMO9LEy4YaSlVXBiPoChzsJfCE&e= > > > Failing Unit Tests: https://urldefense.proofpoint. > > com/v2/url?u=https-3A__ > > > circleci.com_gh_sumanth-2Dpasupuleti_cassandra_84&d=DwIFaQ&c= > > > adz96Xi0w1RHqtPMowiL2g&r=VHsWqsWT2MoX5jRZ0xZfdAWZxBsrn5KzowynGYCJaXE&m= > > > NBUK9LYIuBLTb2_dn7ZZnfqkFQuWmAr69kTsiLgthN8& > > s=oKPrxl_zBsIcuZoHkzS2MZOi9U5_ > > > lF3DaNldTbMQsBU&e= > > > > > > Thanks, > > > Sumanth > > > > > > On Thu, Aug 16, 2018 at 8:22 AM, Jonathan Haddad <j...@jonhaddad.com> > > > wrote: > > > > > > > Pushing it back means it’s a bigger risk later on. I’m +.5 on > upgrading > > > now > > > > > > > > On Wed, Aug 15, 2018 at 11:46 PM dinesh.jo...@yahoo.com.INVALID > > > > <dinesh.jo...@yahoo.com.invalid> wrote: > > > > > > > > > Jason, > > > > > Given that we're so close to the 9/1 date, I would err on the side > of > > > > > caution especially given the low value prop. If someone does run > into > > > > Guava > > > > > compatibility issues (and someone somewhere will), we can revisit > > this > > > > > question then. > > > > > Dinesh > > > > > > > > > > On Wednesday, August 15, 2018, 11:42:31 PM PDT, Dinesh A. > Joshi < > > > > > dinesh.jo...@gatech.edu> wrote: > > > > > > > > > > Jason, > > > > > Given that we're so close to the 9/1 date, I would err on the side > of > > > > > caution especially given the low value prop. If someone does run > into > > > > Guava > > > > > compatibility issues (and someone somewhere will), we can revisit > > this > > > > > question then. > > > > > Dinesh > > > > > > > > > > On Wednesday, August 15, 2018, 8:22:28 AM PDT, Salih Gedik < > > > > > m...@salih.xyz> wrote: > > > > > > > > > > Hi, > > > > > > > > > > Change logs are on Github releases page. It seems like only hash > > > flooding > > > > > protection which is added to ImmutableMap is relevant to Cassandra > > > code. > > > > I > > > > > haven’t checked whether we use deprecated APIs. But there isn’t > much > > on > > > > > table from what I see. > > > > > > > > > > Salih > > > > > On 15 Aug 2018 17:55 +0300, Ariel Weisberg <ar...@weisberg.ws>, > > wrote: > > > > > > Hi, > > > > > > > > > > > > They don't even do release notes after 23. Also no API diffs. I > > mean > > > > I'm > > > > > fine with it, but it's mostly just changing to another arbitrary > > > version > > > > > that won't match what is in apps. > > > > > > > > > > > > Ariel > > > > > > > > > > > > On Wed, Aug 15, 2018, at 10:48 AM, Jason Brown wrote: > > > > > > > Hey Ariel, > > > > > > > > > > > > > > Tbqh, not that much. I was mostly thinking from the "I have > > > conflicts > > > > > on > > > > > > > guava versions in my app because I pull in cassandra and XYZ > > > > > libraries, and > > > > > > > the transitive dependencies on guava use different versions" > POV. > > > > > Further, > > > > > > > we'll be on this version of guava for 4.0 for at least two > years > > > from > > > > > now. > > > > > > > > > > > > > > As I asked, "does anybody feeling strongly?". Personally, I'm > > sorta > > > > +0 > > > > > to > > > > > > > +0.5, but I was just throwing this out there in case someone > does > > > > > really > > > > > > > think it best we upgrade (and wants to make a contribution). > > > > > > > > > > > > > > -Jason > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Aug 15, 2018 at 7:25 AM, Ariel Weisberg < > > ar...@weisberg.ws > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > What do we get from Guava in exchange for upgrading? > > > > > > > > > > > > > > > > Ariel > > > > > > > > > > > > > > > > On Wed, Aug 15, 2018, at 10:19 AM, Jason Brown wrote: > > > > > > > > > Hey all, > > > > > > > > > > > > > > > > > > Does anyone feel strongly about upgrading guava on trunk > > before > > > > > the 9/1 > > > > > > > > > feature freeze for 4.0? We are currently at 23.3 (thanks to > > > > > > > > > CASSANDRA-13997), and the current is 26.0. > > > > > > > > > > > > > > > > > > I took a quick look, and there's about 17 compilation > errors. > > > > They > > > > > fall > > > > > > > > > into two categories, both of which appear not too difficult > > to > > > > > resolve (I > > > > > > > > > didn't look too closely, tbh). > > > > > > > > > > > > > > > > > > If anyone wants to tackle this LHF I can rustle up some > > review > > > > > time. > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > > > -Jason > > > > > > > > > > > > > > > > ------------------------------------------------------------ > > > > --------- > > > > > > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > > > > > > For additional commands, e-mail: > dev-h...@cassandra.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------ > > > --------- > > > > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > > > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > > > > > > > > > > -- > > > > Jon Haddad > > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__www. > > > rustyrazorblade.com&d=DwIFaQ&c=adz96Xi0w1RHqtPMowiL2g&r= > > > VHsWqsWT2MoX5jRZ0xZfdAWZxBsrn5KzowynGYCJaXE&m=NBUK9LYIuBLTb2_ > > > dn7ZZnfqkFQuWmAr69kTsiLgthN8&s=V9h6jcKsRGukN42TFOU5NBaRqefUZ7 > > > M8Edk0OCGwQMM&e= > > > > twitter: rustyrazorblade > > > > > > > > > >
